chore(eslint): use eslint-plugin-n; lint all cjs files (#533)

Co-authored-by: Radu-Cristian Popa <[email protected]>

Author: sidvishnoi

.eslintrc.json

@@ -1,6 +1,6 @@
 {
   "env": {
-    "es2020": true,
+    "es2022": true,
     "browser": true,
     "node": true
   },
@@ -15,7 +15,7 @@
   "parser": "@typescript-eslint/parser",
   "parserOptions": {
     "sourceType": "module",
-    "ecmaVersion": 2020,
+    "ecmaVersion": 2022,
     "ecmaFeatures": {
       "jsx": true
     }
@@ -72,7 +72,12 @@
   },
   "overrides": [
     {
-      "files": [".*rc.js", ".*rc.cjs", "*.config.js", "*.config.cjs"],
+      "extends": [
+        "eslint:recommended",
+        "plugin:@typescript-eslint/recommended",
+        "plugin:n/recommended"
+      ],
+      "files": ["**/*.js", "**/*.cjs"],
       "env": {
         "node": true
       }

.github/actions/bump-manifest-version.cjs

@@ -1,5 +1,5 @@
 // @ts-check
-/* eslint-disable @typescript-eslint/no-var-requires, no-console */
+/* eslint-disable @typescript-eslint/no-require-imports, no-console */
 const fs = require('node:fs/promises')
 
 /** @param {import('github-script').AsyncFunctionArguments} AsyncFunctionArguments */

.github/actions/delete-artifacts.cjs

@@ -1,5 +1,5 @@
 // @ts-check
-/* eslint-disable @typescript-eslint/no-var-requires, no-console */
+/* eslint-disable @typescript-eslint/no-require-imports, no-console */
 const { BROWSERS } = require('./constants.cjs')
 
 /**

.github/actions/get-built-version.cjs

@@ -1,5 +1,5 @@
 // @ts-check
-/* eslint-disable @typescript-eslint/no-unused-vars, @typescript-eslint/no-var-requires */
+/* eslint-disable @typescript-eslint/no-require-imports */
 const fs = require('node:fs/promises')
 
 /**

.github/actions/get-workflow-artifacts.cjs

@@ -1,5 +1,5 @@
 // @ts-check
-/* eslint-disable @typescript-eslint/no-var-requires, no-console */
+/* eslint-disable @typescript-eslint/no-require-imports, no-console */
 const fs = require('node:fs/promises')
 const { COLORS, TEMPLATE_VARS, BADGE } = require('./constants.cjs')
 

package.json

@@ -65,7 +65,7 @@
     "eslint-plugin-html": "^8.1.1",
     "eslint-plugin-jest": "^28.8.0",
     "eslint-plugin-jsx-a11y": "^6.9.0",
-    "eslint-plugin-node": "^11.1.0",
+    "eslint-plugin-n": "^17.10.2",
     "eslint-plugin-react": "^7.35.0",
     "eslint-plugin-react-hooks": "^4.6.2",
     "jest": "^29.7.0",

pnpm-lock.yaml

@@ -15,6 +15,7 @@
     "allowSyntheticDefaultImports": true,
     "allowUmdGlobalAccess": true,
     "resolveJsonModule": true,
+    "noEmit": true,
     "paths": {
       "@/shared/*": ["./shared/*"],
       "@/popup/*": ["./popup/*"],