Allow specifying S3 region in url as "s3://<bucket>.s3.<region>.amazo… (#427)

Allow specifying S3 region in url as "s3://<bucket>.s3.<region>.amazonaws.com"

Author: irees

request/s3.go

@@ -3,6 +3,7 @@ package request
 import (
 	"context"
 	"errors"
+	"fmt"
 	"io"
 	"net/url"
 	"strings"
@@ -31,10 +32,20 @@ func NewS3FromUrl(ustr string) (*S3, error) {
 	if err != nil {
 		return nil, err
 	}
+	bucket := strings.TrimPrefix(u.Host, "s3://")
+
+	// Is bucket in the form <bucket>.s3.<region>.amazonaws.com?
+	bucketRegion := ""
+	if a := strings.Split(bucket, "."); len(a) == 5 && a[1] == "s3" {
+		bucket = a[0]
+		bucketRegion = a[2]
+	}
 	s := S3{
-		Bucket:    trimSlash(strings.TrimPrefix(u.Host, "s3://")),
+		Bucket:    trimSlash(bucket),
 		KeyPrefix: trimSlash(u.Path),
 	}
+	s.secret.AWSRegion = bucketRegion
+	fmt.Printf("s: %#v\n", s)
 	return &s, nil
 }
 

request/s3_test.go

@@ -19,3 +19,8 @@ func TestS3(t *testing.T) {
 	}
 	testBucket(t, ctx, b)
 }
+
+func TestAsd(t *testing.T) {
+	s, _ := NewS3FromUrl("s3://asd.s3.us-west-2.amazonaws.com/asd123")
+	_ = s
+}