From 31570967b98725bb26e2a4b3cae97fde4e57ef40 Mon Sep 17 00:00:00 2001 From: Mek Date: Thu, 30 Jan 2025 10:14:00 -0800 Subject: [PATCH 1/3] add_book_cover_from_url --- olclient/openlibrary.py | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/olclient/openlibrary.py b/olclient/openlibrary.py index b16ddd3d..756b519c 100644 --- a/olclient/openlibrary.py +++ b/olclient/openlibrary.py @@ -263,6 +263,18 @@ def add_bookcover(self, cover_url): ) return r + def add_book_cover_from_url(self, cover_url, file_name="cover.jpg", mime_type="image/jpeg"): + response = requests.get(cover_url) + + if response.status_code != 200: + raise ValueError(f"Failed to download image from {cover_url}. Status code: {response.status_code}") + + return self.add_book_cover_from_file( + file_name=file_name, + cover_data=response.content, + mime_type=mime_type + )): + def add_book_cover_from_file( self, file_name: str, From 26333b9c834d4138d2206567ac24b71a2bf2c133 Mon Sep 17 00:00:00 2001 From: Mek Date: Thu, 30 Jan 2025 10:15:41 -0800 Subject: [PATCH 2/3] fix typo --- olclient/openlibrary.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/olclient/openlibrary.py b/olclient/openlibrary.py index 756b519c..baa5be03 100644 --- a/olclient/openlibrary.py +++ b/olclient/openlibrary.py @@ -273,7 +273,7 @@ def add_book_cover_from_url(self, cover_url, file_name="cover.jpg", mime_type="i file_name=file_name, cover_data=response.content, mime_type=mime_type - )): + ) def add_book_cover_from_file( self, From fe1cd36a74e3d60ab8e099468656aadb19a385c3 Mon Sep 17 00:00:00 2001 From: Mek Date: Thu, 30 Jan 2025 10:46:56 -0800 Subject: [PATCH 3/3] change function ordering --- olclient/openlibrary.py | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/olclient/openlibrary.py b/olclient/openlibrary.py index baa5be03..abc02ee6 100644 --- a/olclient/openlibrary.py +++ b/olclient/openlibrary.py @@ -263,18 +263,6 @@ def add_bookcover(self, cover_url): ) return r - def add_book_cover_from_url(self, cover_url, file_name="cover.jpg", mime_type="image/jpeg"): - response = requests.get(cover_url) - - if response.status_code != 200: - raise ValueError(f"Failed to download image from {cover_url}. Status code: {response.status_code}") - - return self.add_book_cover_from_file( - file_name=file_name, - cover_data=response.content, - mime_type=mime_type - ) - def add_book_cover_from_file( self, file_name: str, @@ -291,6 +279,18 @@ def add_book_cover_from_file( files=form_data_body ) + def add_book_cover_from_url(self, cover_url, file_name="cover.jpg", mime_type="image/jpeg"): + response = requests.get(cover_url) + + if response.status_code != 200: + raise ValueError(f"Failed to download image from {cover_url}. Status code: {response.status_code}") + + return self.add_book_cover_from_file( + file_name=file_name, + cover_data=response.content, + mime_type=mime_type + ) + def save(self, comment): """Saves this edition back to Open Library using the JSON API.""" body = self.json()