-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Closed
Labels
Good First IssueEasy issue. Good for newcomers. [managed]Easy issue. Good for newcomers. [managed]Lead: @cdriniIssues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed]Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed]Needs: BreakdownThis big issue needs a checklist or subissues to describe a breakdown of work. [managed]This big issue needs a checklist or subissues to describe a breakdown of work. [managed]Needs: ResponseIssues which require feedback from leadIssues which require feedback from leadPriority: 3Issues that we can consider at our leisure. [managed]Issues that we can consider at our leisure. [managed]Theme: ListsIssues related to reading ListsIssues related to reading ListsType: BugSomething isn't working. [managed]Something isn't working. [managed]
Description
Problem
When a list is in grid layout view, notes will flow beyond their designated book's grid box, potentially overlapping covers and notes for adjacent books in the list.
Reproducing the bug
- Go to https://openlibrary.org/people/something999/lists/OL302846L/Pulitzer_Prize_Winners_-_Biography
- Select Grid (layout).
- Scroll down to the grid box for Booker T. Washington by Louis R. Harlan (second-to-last row, second from the left).
This bug can also be seen with the grid box for the book W.E.B. Du Bois by David Levering Lewis (fifth row from the bottom, first on the left). The description also overflows the expected boundary but is partially hidden by the cover of another book.
- Expected behavior: The grid box shows notes up to a certain character limit (truncation).
- Actual behavior: The grid box does not appear to have a boundary.
Context
- Browser (Chrome, Safari, Firefox, etc): Firefox
- OS (Windows, Mac, etc): Windows
- Logged in (Y/N): N
- Environment (prod, dev, local): prod
Breakdown
Requirements Checklist
- [ ]
Related files
Stakeholders
Instructions for Contributors
- Please run these commands to ensure your repository is up to date before creating a new branch to work on this issue and each time after pushing code to Github, because the pre-commit bot may add commits to your PRs upstream.
Metadata
Metadata
Assignees
Labels
Good First IssueEasy issue. Good for newcomers. [managed]Easy issue. Good for newcomers. [managed]Lead: @cdriniIssues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed]Issues overseen by Drini (Staff: Team Lead & Solr, Library Explorer, i18n) [managed]Needs: BreakdownThis big issue needs a checklist or subissues to describe a breakdown of work. [managed]This big issue needs a checklist or subissues to describe a breakdown of work. [managed]Needs: ResponseIssues which require feedback from leadIssues which require feedback from leadPriority: 3Issues that we can consider at our leisure. [managed]Issues that we can consider at our leisure. [managed]Theme: ListsIssues related to reading ListsIssues related to reading ListsType: BugSomething isn't working. [managed]Something isn't working. [managed]