codeclimate refactor and stub function to the test

Author: OlegPhenomenon

app/controllers/admin/invoices/mark_as_paids_controller.rb

@@ -1,38 +1,40 @@
 module Admin
-  class Invoices::MarkAsPaidsController < BaseController
-    rescue_from Errors::InvoiceAlreadyPaid, with: :invoice_already_paid
+  module Invoices
+    class MarkAsPaidsController < BaseController
+      rescue_from Errors::InvoiceAlreadyPaid, with: :invoice_already_paid
 
-    before_action :set_invoice
-    
-    # order is important! before set invoice, otherwise @invoice wont be set
-    include ::Invoices::UpdateAuthorizable
+      before_action :set_invoice
 
-    def edit; end
+      # order is important! before set invoice, otherwise @invoice wont be set
+      include ::Invoices::UpdateAuthorizable
 
-    def update
-      raise(Errors::InvoiceAlreadyPaid, @invoice.id) if @invoice.paid?
+      def edit; end
 
-      @invoice.assign_attributes(invoice_params)
-      @invoice.mark_as_paid_at(invoice_params[:paid_at])
-      @invoice.save!
+      def update
+        raise(Errors::InvoiceAlreadyPaid, @invoice.id) if @invoice.paid?
 
-      flash[:notice] = t('invoices.marked_as_paid')
-      redirect_to admin_invoice_path(@invoice), status: :see_other
-    end
+        @invoice.assign_attributes(invoice_params)
+        @invoice.mark_as_paid_at(invoice_params[:paid_at])
+        @invoice.save!
 
-    private
+        flash[:notice] = t('invoices.marked_as_paid')
+        redirect_to admin_invoice_path(@invoice), status: :see_other
+      end
 
-    def set_invoice
-      @invoice = Invoice.find(params[:invoice_id])
-    end
+      private
 
-    def invoice_already_paid
-      flash[:alert] = t('invoices.already_paid')
-      redirect_to admin_invoice_path(@invoice), status: :see_other
-    end
+      def set_invoice
+        @invoice = Invoice.find(params[:invoice_id])
+      end
+
+      def invoice_already_paid
+        flash[:alert] = t('invoices.already_paid')
+        redirect_to admin_invoice_path(@invoice), status: :see_other
+      end
 
-    def invoice_params
-      params.require(:invoice).permit(:notes, :paid_at)
+      def invoice_params
+        params.require(:invoice).permit(:notes, :paid_at)
+      end
     end
   end
-end
+end

app/controllers/admin/invoices/toggle_partial_payments_controller.rb

@@ -1,24 +1,24 @@
 module Admin
-  class Invoices::TogglePartialPaymentsController < BaseController
-    before_action :set_invoice
+  module Invoices
+    class TogglePartialPaymentsController < BaseController
+      before_action :set_invoice
 
-    # order is important! before set invoice, otherwise @invoice wont be set
-    include ::Invoices::UpdateAuthorizable
+      # order is important! before set invoice, otherwise @invoice wont be set
+      include ::Invoices::UpdateAuthorizable
 
-    def update
-      if @invoice.toggle(:partial_payments).save
-        action = @invoice.partial_payments? ? 'activated' : 'deactivated'
-        redirect_to admin_invoice_path(@invoice), notice: t("invoices.partial_payments_#{action}"), status: :see_other
-      else
-        redirect_to admin_invoice_path(@invoice), alert: t(:something_went_wrong), status: :see_other
+      def update
+        if @invoice.toggle(:partial_payments).save
+
+          action = @invoice.partial_payments? ? 'activated' : 'deactivated'
+          redirect_to admin_invoice_path(@invoice), notice: t("invoices.partial_payments_#{action}"), status: :see_other
+        else
+          redirect_to admin_invoice_path(@invoice), alert: t(:something_went_wrong), status: :see_other
+        end
       end
-    rescue StandardError => e
-      Rails.logger.error "Error toggling partial payments: #{e.message}"
-      redirect_to admin_invoice_path(@invoice), alert: t(:something_went_wrong), status: :see_other
-    end
 
-    def set_invoice 
-      @invoice = Invoice.find(params[:invoice_id])
+      def set_invoice
+        @invoice = Invoice.find(params[:invoice_id])
+      end
     end
   end
-end
+end

app/controllers/concerns/invoices/update_authorizable.rb

@@ -17,4 +17,4 @@ def authorize_for_update
       authorize! :update, @invoice
     end
   end
-end
+end

test/controllers/admin/invoices/mark_as_paids_controller_test.rb

@@ -6,6 +6,9 @@ class Invoices::MarkAsPaidControllerTest < ActionDispatch::IntegrationTest
       @user = users(:administrator)
       sign_in @user
       @invoice = invoices(:payable)
+
+      stub_request(:patch, 'http://eis_billing_system:3000/api/v1/invoice/update_invoice_data')
+        .to_return(status: 200, body: @message.to_json, headers: {})
     end
 
     test 'should mark invoice as paid' do