Skip to content

Commit 97f3b24

Browse files
committed
Fix SHA1 KEX hash
1 parent aa92db8 commit 97f3b24

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

checks/tasks/tls/scans.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -945,9 +945,10 @@ def _test_connection_with_limited_sigalgs(
945945
try:
946946
ssl_connection.connect()
947947
sigalg_nid = ssl_connection.ssl_client.get_peer_signature_nid()
948-
# Extra check as some servers will ignore the client, and force a secure hash anyways.
948+
# Extra check as some servers will ignore the client and force a secure hash anyways.
949949
# OpenSSL will accept this, as it does know about the secure hash.
950-
if sigalg_nid in sigalgs:
950+
# Note that while we can double-check this for the digest hash, we cannot check it for EVP PKEY.
951+
if sigalg_nid in [sa[0] for sa in sigalgs]:
951952
return sigalg_nid
952953
except (ClientCertificateRequested, ServerRejectedTlsHandshake, TlsHandshakeTimedOut, OpenSSLError):
953954
pass

0 commit comments

Comments
 (0)