Crash on SPF with invalid terms

[sentry]

This error is raised when a mailtest is done and there are no mailservers. The cause lies in this shared code:

Internet.nl/checks/tasks/shared.py

Lines 162 to 163 in ec67e3d

	spf_parsed = spf_parse(spf_data)
	if spf_parsed.get("terms", []) == ["-all"]:

It is probably None due to:

Internet.nl/checks/tasks/spf_parser.py

Lines 150 to 151 in ec67e3d

	except ParseException:
	parsed = None

Examples:

Example: https://internet.nl/mail/www.wouter-kobes.nl/

Specific crash when SPF record is "v=spf1 a aaaa -all"

Another crash: https://internet.nl/mail/cms.waterkwaliteitscheck.nl/

SPF record is "v=spf1" "a" "-all"

Another crash: https://internet.nl/mail/eindhovensport.nl/

SPF record is "v=spf1 include:_spf.spotler.email ip4:ip4:195.8.64.64/28 -all" note double ip4:

Another crash: https://internet.nl/mail/geoforum.nl and https://internet.nl/mail/kaartvannederland.nl and https://internet.nl/mail/onderzoek.wegwijzer.overheid.nl/

SPF record is "v=spf1" "-all"

---

Sentry Issue: INTERNETNL-39B

AttributeError: 'NoneType' object has no attribute 'get'
ChordError: Dependency 81914ab5-ca3c-4589-b697-820e97ee2aea raised AttributeError("'NoneType' object has no attribute 'get'")
  File "celery/backends/redis.py", line 575, in on_chord_part_return
    resl = [unpack(tup, decode) for tup in resl]
  File "celery/backends/redis.py", line 481, in _unpack_chord_result
    raise chord_error

Chord '6aec9fcb-8ee0-4cca-af3f-44932c9883e4' raised: ChordError('Dependency 81914ab5-ca3c-4589-b697-820e97ee2aea raised AttributeError("\'NoneType\' object has no attribute \'get\'")')