Skip to content

Commit 067483f

Browse files
committed
fix for default values
1 parent 51ac69f commit 067483f

File tree

1 file changed

+12
-12
lines changed

1 file changed

+12
-12
lines changed

.github/workflows/deployment.yml

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -31,11 +31,9 @@ on:
3131
memory:
3232
description: 'Memory for the instance'
3333
type: string
34-
default: 512Mi
3534
port:
3635
description: 'WebPort for the running instance'
3736
type: string
38-
default: "52773"
3937

4038
env:
4139
# Change this section according to your needs
@@ -50,6 +48,8 @@ env:
5048
GCR_LOCATION: eu.gcr.io
5149
REGION: europe-west2
5250
NAMESPACE: demo
51+
SERVICE_PORT: ${{ inputs.port }}
52+
SERVICE_MEMORY: ${{ inputs.memory }}
5353

5454
jobs:
5555
deploy-cloud-run:
@@ -95,16 +95,16 @@ jobs:
9595
gcloud config set project ${PROJECT_ID}
9696
9797
echo "[INFO] Deploy service..."
98-
gcloud run deploy ${SERVICE} \
99-
--platform gke \
100-
--cluster ${CLUSTER_NAME} \
101-
--cluster-location ${REGION} \
102-
--namespace ${NAMESPACE} \
103-
--port ${{ inputs.port }} \
104-
--min-instances 1 \
105-
--memory ${{ inputs.memory }} \
106-
--timeout 300 \
107-
--verbosity debug \
98+
gcloud run deploy ${SERVICE} \
99+
--platform gke \
100+
--cluster ${CLUSTER_NAME} \
101+
--cluster-location ${REGION} \
102+
--namespace ${NAMESPACE} \
103+
--port ${SERVICE_PORT:-52773} \
104+
--min-instances 1 \
105+
--memory ${SERVICE_MEMORY:-512Mi} \
106+
--timeout 300 \
107+
--verbosity debug \
108108
--image ${GCR_LOCATION}/${PROJECT_ID}/${IMAGE_NAME}:${GITHUB_SHA}
109109
110110
echo "[INFO] Create domain mappings..."

0 commit comments

Comments
 (0)