Preserve case of username in scopes[1] so getSession caller can obtain it exactly (required when case-sensitive external authorization is being used) (#281)

* Preserve case of username in `session.account.id` so `getSession` caller can obtain it

* Update a line of README code sample

* Support case-sensitive usernames

* Convert indenting to tabs (standard for this project)

* No longer lowercase userName in account.id

* Revert README usage example code change (no longer needed)

* Remove a stray `toLowerCase()`

* Revert an obsolete change

Author: gjsjohnmurray

README.md

@@ -263,7 +263,7 @@ To obtain the password with which to connect, use code like this which will also
       session = await vscode.authentication.getSession(serverManager.AUTHENTICATION_PROVIDER, scopes, { createIfNone: true, account });
     }
     if (session) {
-      serverSpec.username = session.scopes[1];
+	  serverSpec.username = session.scopes[1].toLowerCase() === "unknownuser" ? "" : session.scopes[1];
       serverSpec.password = session.accessToken;
     }
   }

src/authenticationProvider.ts

@@ -63,15 +63,15 @@ export class ServerManagerAuthenticationProvider implements AuthenticationProvid
 
 		// Filter to return only those that match all supplied scopes, which are positional and case-insensitive.
 		for (let index = 0; index < scopes.length; index++) {
-			sessions = sessions.filter((session) => session.scopes[index] === scopes[index].toLowerCase());
+			sessions = sessions.filter((session) => session.scopes[index].toLowerCase() === scopes[index].toLowerCase());
 		}
 
 		if (options.account) {
 			const accountParts = options.account.id.split("/");
 			const serverName = accountParts.shift();
-			const userName = accountParts.join('/').toLowerCase();
+			const userName = accountParts.join('/');
 			if (serverName && userName) {
-				sessions = sessions.filter((session) => session.scopes[0] === serverName && session.scopes[1] === userName);
+				sessions = sessions.filter((session) => session.scopes[0] === serverName && session.scopes[1].toLowerCase() === userName.toLowerCase());
 			}
 		}
 

src/authenticationSession.ts

@@ -11,10 +11,9 @@ export class ServerManagerAuthenticationSession implements AuthenticationSession
 		public readonly userName: string,
 		password: string,
 	) {
-		const canonicalUserName = userName.toLowerCase();
 		this.id = ServerManagerAuthenticationProvider.sessionId(serverName, userName);
 		this.accessToken = password;
-		this.account = { id: `${serverName}/${canonicalUserName}`, label: `${userName} on ${serverName}` };
-		this.scopes = [serverName, canonicalUserName];
+		this.account = { id: `${serverName}/${userName}`, label: `${userName} on ${serverName}` };
+		this.scopes = [serverName, userName];
 	}
 }