Compromise by removing namespace-specific Simple Browser variant

Author: gjsjohnmurray

package.json

@@ -302,14 +302,9 @@
         "title": "Open Management Portal in Tab",
         "icon": "$(tools)"
       },
-      {
-        "command": "intersystems-community.servermanager.openPortalExplorerTab",
-        "title": "Open Management Portal's Class Utilities in Tab",
-        "icon": "$(tools)"
-      },
       {
         "command": "intersystems-community.servermanager.openPortalExplorerExternal",
-        "title": "Open in External Browser",
+        "title": "Open Management Portal Here in External Browser",
         "icon": "$(link-external)"
       },
       {
@@ -459,10 +454,6 @@
           "command": "intersystems-community.servermanager.openPortalExplorerExternal",
           "when": "false"
         },
-        {
-          "command": "intersystems-community.servermanager.openPortalExplorerTab",
-          "when": "false"
-        },
         {
           "command": "intersystems-community.servermanager.retryServer",
           "when": "false"
@@ -614,10 +605,9 @@
           "group": "inline@90"
         },
         {
-          "command": "intersystems-community.servermanager.openPortalExplorerTab",
+          "command": "intersystems-community.servermanager.openPortalExplorerExternal",
           "when": "view == intersystems-community_servermanager && viewItem =~ /namespace$/",
-          "group": "inline@80",
-          "alt": "intersystems-community.servermanager.openPortalExplorerExternal"
+          "group": "inline@80"
         },
         {
           "command": "intersystems-community.servermanager.retryServer",

src/extension.ts

@@ -128,25 +128,6 @@ export function activate(context: vscode.ExtensionContext) {
 			}
 		}),
 	);
-	context.subscriptions.push(
-		vscode.commands.registerCommand(`${extensionId}.openPortalExplorerTab`, (namespaceTreeItem?: NamespaceTreeItem) => {
-			if (namespaceTreeItem) {
-				const pathParts = namespaceTreeItem.id?.split(":");
-				if (pathParts && pathParts.length === 4) {
-					const serverName = pathParts[1];
-					const namespace = pathParts[3];
-					getPortalUriWithToken(BrowserTarget.SIMPLE, serverName, "/csp/sys/exp/%2525CSP.UI.Portal.ClassList.zen", namespace).then((uriWithToken) => {
-						if (uriWithToken) {
-							//
-							// It is essential to pass skipEncoding=true when converting the uri to a string,
-							// otherwise the querystring's & and = get encoded.
-							vscode.commands.executeCommand("simpleBrowser.show", uriWithToken.toString(true));
-						}
-					});
-				}
-			}
-		}),
-	);
 	context.subscriptions.push(
 		vscode.commands.registerCommand(`${extensionId}.editSettings`, (server?: ServerTreeItem) => {
 			// Until there's a dedicated settings editor the best we can do is jump to the right section