No actions possible

[globalerp-mhess]

Dear Maintainers,

I am experiencing an issue with the Server Manager extension where the server icons specified in .vscode/settings.json are unresponsive.

Here are the details:

Steps to Reproduce:

1. Open a .code-workspace file that includes one server configuration with objectscript.conn.
2. Have a .vscode/settings.json file with multiple servers.
3. Navigate to the server list in the Server Manager extension.
4. Attempt to interact with any server by clicking on the management portal icons, or the terminal, pencil, eye icons next to the namespaces.

Expected Behavior:

• Clicking on any icon should perform the expected action.

Actual Behavior:

• The server list displays correctly, and namespaces of all servers are visible after connecting.
• However, clicking on any icon (terminal, pencil, eye, or management portal) does not produce any action.
• Only the server specified in the .code-workspace file seems to function correctly.

Configuration:

.code-workspace file:

{
    "folders": [
        {
            "name": "LOCAL",
            "path": "./l"
        }
    ],
    "settings": {
        "objectscript.conn": {
            "active": true,
            "server": "iris4",
            "ns": "CS"
        },
        "intersystems.servers": {
            "iris4": {
                "username": "user",
                "webServer": {
                    "host": "localhost",
                    "port": 52773,
                    "scheme": "http"
                }
            }
        }
    },
    "launch": {}
}

.vscode/settings.json file:

    {
        "intersystems.servers": {
            "iris6": {
                "webServer": {
                    "scheme": "http",
                    "host": "123.456.789.10",
                    "port": 80
                }
            }
        }
    }

Thank you for your assistance in resolving this issue.

For reference about why we need this setup to work, please see the related issues:
intersystems-community/vscode-objectscript#1554
#272

[isc-bsaviano]

Hi @globalerp-mhess, thanks for reporting this. I was able to reproduce it, but only when connected to the server definition in in the local .vscode/settings.json file.

[isc-bsaviano]

@globalerp-mhess After investigating this, I think there are a few changes we need to make to improve how we handle these workspace-folder-level servers:

1. Hide the "pencil" and "eye" icons. It doesn't make sense to allow the creation of server-side workspace folders for servers that are only defined within another workspace folder. The created server-side folders will not work.
2. Fix the Launch Lite Terminal command. This is contributed by the vscode-objectscript extension.
3. Figure out what to do about the SMP links. I am still in favor of removing them but they must be fixed as well if kept.

@gjsjohnmurray I'll work on 2 now but 1 and 3 need your comment.

[globalerp-mhess]

@isc-bsaviano
I appreciate the proposed changes to improve how workspace-folder-level servers are handled.
However, I would like to provide additional context to ensure that our requirements are fully understood:

1. Centralized Server Definitions:

   • Our primary goal is to maintain a centralized list of server configurations.
   • These configurations should be copied and updated from a centralized folder to each developer's .vscode/settings.json.
   • This ensures that all developers have the latest server configurations, including changes to IPs, ports, etc.
   • We have over 30 server configurations. Without centralization, managing these configurations individually would be error-prone and inefficient.

2. Workspace vs. User Settings:

   • We need a clear separation between workspace-level settings (which are centrally managed) and user-specific settings (which should remain local).
   • Each developer has their own namespace on our server for active development. This information must remain local (specifically the objectscript.conn property). This is crucial because all changes made by the developer need to be imported into their own namespace.
   • The current behavior of the extension does not support this separation.

3. Functionality of Server Icons:

   • The unresponsiveness of server icons (terminal, pencil, eye, SMP links) is a significant issue because it prevents developers from performing essential tasks directly from the server list.
   • We need these icons to be functional to streamline our workflow.

We understand the proposed changes and appreciate your efforts to address these issues. However, we would like to ensure that the functionality we need is fully supported.

If the initially proposed way is not the right one, we are open to any other suggestions or approaches that can help us achieve our goals.

One suggestion we have is to consider separating out certain properties into different configuration files. Maybe even optional.
Specifically, it would be beneficial if at least the objectscript.conn property, and possibly even the intersystems.servers property, could each be sourced out into separate configuration files. This separation of concerns would allow us to manage these configurations more effectively and reduce conflicts between centralized and local settings.

Thank you for your continued assistance.

[isc-bsaviano]

Hi @globalerp-mhess, I understand the folder structure you want, but I'm pretty sure it's already supported. Based on your description, what I think you want is this:
.code-workspace:

{
    "folders": [
        {
            "name": "LOCAL",
            "path": "./l"
        }
    ],
    "settings": {
        // Common server definitions
        "intersystems.servers": {
            "iris4": {
                "username": "user",
                "webServer": {
                    "host": "localhost",
                    "port": 52773,
                    "scheme": "http"
                }
            }
        }
    },
    "launch": {}
}

.vscode/settings.json:

{
    "objectscript.conn": {
   // ...
    }
}

This should definitely work, and if it doesn't we will identify and fix the bug. If this is not the model you want, please share sample file contents or update the original ones in this issue description.

The unresponsiveness of server icons (terminal, pencil, eye, SMP links) is a significant issue because it prevents developers from performing essential tasks directly from the server list.

With the structure above, these will all work. I also fixed the terminal icon for the case where the server definition is in the local settings.json file. Since you are using client-side editing (local files), you shouldn't need to use the pencil or eye icons because those are for server-side editing. The SMP can also be accessed from the Server Actions menu.

One suggestion we have is to consider separating out certain properties into different configuration files. Maybe even optional. Specifically, it would be beneficial if at least the objectscript.conn property, and possibly even the intersystems.servers property, could each be sourced out into separate configuration files.

We do support putting these in different VS Code settings files (user, workspace, or folder settings). We are not going to introduce our own config files outsode of VS Code's settings system.

[globalerp-mhess]

@isc-bsaviano
Thank you for your continued support and suggestions.
However, the proposed setup does not fully address our operational requirements.

Here are the key concerns:

• Local objectscript.conn Property:
  - The objectscript.conn property must remain local to each developer's environment because it contains individual namespace settings crucial for their development work.
  - Placing this in a shared .vscode/settings.json file is not feasible for our workflow.

• Functionality of objectscript.conn:
  - We explored injecting the property into the .vscode/settings.json after loading the centralized managed version into the workspace.
  - This would need the username to be defined inside the server configuration of the server used by objectscript.conn.
  - Using the username property within objectscript.conn, seems to lack the necessary functionality unless paired with a password, which we aim to avoid for security reasons.
  - Injecting the property objectscript.conn with the individual namespace and the server configuration of our development server with the individual username seems overly complex and impractical.

Given these constraints, we are looking for a solution that allows us to:
- Maintain centralized server configurations for consistency across all developers.
- Keep local settings, particularly objectscript.conn, separate.
- Ensure that all server management functionalities (terminal, SMP links, etc.) work seamlessly within this setup.

We appreciate your efforts and are open to further suggestions or alternative approaches that could help us achieve these goals.
If there are any additional insights or potential adjustments to the extension that could accommodate these needs, we would be grateful for your guidance.

Thank you for your understanding and support.

[isc-bsaviano]

@globalerp-mhess I re-read our last conversation and I think I know what you want. Is this correct?

.code-workspace (not in source control, unique per developer):

{
    "folders": [
        {
            // Your source-controlled folder
            "name": "LOCAL",
            "path": "./l"
        }
    ],
    "settings": {
        "objectscript.conn": {
            "active": true,
            // Server defined in .vscode/settings.json
            "server": "iris4",
            "ns": "CS"
        }
    },
    "launch": {}
}

.vscode/settings.json (in your source-controlled directory, shared):

{
    // Shared server definitions
    "intersystems.servers": {
        "iris4": {
            "webServer": {
                "scheme": "http",
                "host": "123.456.789.10",
                "port": 80
            }
        }
    }
}

If this is indeed what you're can you explain what specific features don't work besides the Servers tree buttons? This should be fully supported.

[globalerp-mhess]

@isc-bsaviano
If we place all servers, including our development server (without a username), inside the .vscode/settings.json and only objectscript.conn inside the .code-workspace file, we can't even choose any server after we click on the "Choose Server and Namespace" button.

Thank you for your help!

[isc-bsaviano]

@globalerp-mhess Those servers are probably not showing because the main extension is not passing the workspace folder to this extension when it's requesting the server list. I can fix that, but you can work around it by editing the settings files directly instead of using the UI. You shouldn't need to choose a server if you've added the objectscript.conn to the .code-workpsace file and then opened the workspace.

[globalerp-mhess]

@isc-bsaviano
Is your workaround to add the server list to the .code-workspace file temporarily?

Because otherwise, when I only have objectscript.conn in the .code-workspace file and set active to true and open the .code-workspace file I get this error:

However, we look forward to your fix!

[isc-bsaviano]

I will try to reproduce that and will check back in when I can. Thanks for your patience.

[isc-bsaviano]

@globalerp-mhess I have just opened a PR in this extension that fixes the remaining issues with the tree icon commands. You can try it out using the dev version below. I am still working on the fixes to the main extension.

servermanager-3.10.4-dev.287.vsix.zip

[globalerp-mhess]

@isc-bsaviano
First of all, thank you for providing the dev build and for continuing to work through this issue.
We tested it and can confirm that the action icons in the Servers tree are now correctly hidden in the situation we described.
That part is working as expected.

We understand this is only an interim step, and we appreciate the quick turnaround to improve the experience in the meantime.

If you’ll allow us a quick clarification (and apologies if this is overexplaining), we just want to make sure we’ve correctly understood your current plan — so we don’t accidentally test or expect the wrong thing:

• The dev build hides non-functional action icons in the tree view if the server is defined only in .vscode/settings.json.
• The underlying issue (that the main extension wasn’t passing the workspace folder context to the Server Manager) is being addressed separately.
• Once that fix is in place, the action icons should work again for those centrally defined servers, even if objectscript.conn is local in the .code-workspace file, while the servers are defined in the .vscode/settings.json.
• The "Choose Server and Namespace" UI may also start working again as expected in that setup.

Is that understanding correct?
If so, that would address our use case perfectly, and we’ll be happy to test the final fix once it’s available in the main extension.

Thanks again for the support and transparency throughout this!

[isc-bsaviano]

Hi @globalerp-mhess, thanks for trying the dev build! intersystems-community/vscode-objectscript#1628 addresses the main extension issues related to "Choose Server and Namespace". You can test out the fix using the dev vsix below. With the two dev builds, all of the shown icons in the Servers tree will work. However, the icons for creating server-side editing workspace folders (the pencil and eye) will still be hidden. It's not possible to make those work for folders defined at the workspace folder level because the newly created workspace folders can't access the settings scoped to another folder.

vscode-objectscript-3.0.6-dev.1628.vsix.zip