Reduce firing of OpenedDocument action for projects (#1319)

Author: isc-bsaviano

src/commands/unitTest.ts

@@ -5,7 +5,6 @@ import { getFileText, methodOffsetToLine, outputChannel, stripClassMemberNameQuo
 import { fileSpecFromURI } from "../utils/FileProviderUtil";
 import { AtelierAPI } from "../api";
 import { DocumentContentProvider } from "../providers/DocumentContentProvider";
-import { StudioActions, OtherStudioAction } from "./studio";
 
 enum TestStatus {
   Failed = 0,
@@ -276,12 +275,6 @@ async function childrenForServerSideFolderItem(
   const params = new URLSearchParams(item.uri.query);
   const api = new AtelierAPI(item.uri);
   if (params.has("project")) {
-    // Technically a project is a "document", so tell the server that we're opening it
-    await new StudioActions()
-      .fireProjectUserAction(api, params.get("project"), OtherStudioAction.OpenedDocument)
-      .catch(() => {
-        // Swallow error because showing it is more disruptive than using a potentially outdated project definition
-      });
     query =
       "SELECT DISTINCT CASE " +
       "WHEN $LENGTH(SUBSTR(Name,?),'.') > 1 THEN $PIECE(SUBSTR(Name,?),'.') " +

src/providers/FileSystemProvider/FileSearchProvider.ts

@@ -3,8 +3,6 @@ import { projectContentsFromUri, studioOpenDialogFromURI } from "../../utils/Fil
 import { notNull } from "../../utils";
 import { DocumentContentProvider } from "../DocumentContentProvider";
 import { ProjectItem } from "../../commands/project";
-import { StudioActions, OtherStudioAction } from "../../commands/studio";
-import { AtelierAPI } from "../../api";
 
 export class FileSearchProvider implements vscode.FileSearchProvider {
   /**
@@ -23,16 +21,6 @@ export class FileSearchProvider implements vscode.FileSearchProvider {
     const params = new URLSearchParams(options.folder.query);
     const csp = params.has("csp") && ["", "1"].includes(params.get("csp"));
     if (params.has("project") && params.get("project").length) {
-      // Technically a project is a "document", so tell the server that we're opening it
-      await new StudioActions()
-        .fireProjectUserAction(new AtelierAPI(options.folder), params.get("project"), OtherStudioAction.OpenedDocument)
-        .catch(() => {
-          // Swallow error because showing it is more disruptive than using a potentially outdated project definition
-        });
-      if (token.isCancellationRequested) {
-        return;
-      }
-
       const patternRegex = new RegExp(`.*${pattern}.*`.replace(/\.|\//g, "[./]"), "i");
       return projectContentsFromUri(options.folder, true).then((docs) =>
         docs

src/providers/FileSystemProvider/TextSearchProvider.ts

@@ -6,7 +6,6 @@ import { DocumentContentProvider } from "../DocumentContentProvider";
 import { notNull, outputChannel, throttleRequests } from "../../utils";
 import { config } from "../../extension";
 import { fileSpecFromURI } from "../../utils/FileProviderUtil";
-import { OtherStudioAction, StudioActions } from "../../commands/studio";
 
 /**
  * Convert an `attrline` in a description to a line number in document `content`.
@@ -396,18 +395,6 @@ export class TextSearchProvider implements vscode.TextSearchProvider {
     // Needed because the server matches the full line against the regex and ignores the case parameter when in regex mode
     const pattern = query.isRegExp ? `${!query.isCaseSensitive ? "(?i)" : ""}.*${query.pattern}.*` : query.pattern;
 
-    if (params.has("project") && params.get("project").length) {
-      // Technically a project is a "document", so tell the server that we're opening it
-      await new StudioActions()
-        .fireProjectUserAction(api, params.get("project"), OtherStudioAction.OpenedDocument)
-        .catch(() => {
-          // Swallow error because showing it is more disruptive than using a potentially outdated project definition
-        });
-    }
-    if (token.isCancellationRequested) {
-      return;
-    }
-
     if (api.config.apiVersion >= 6) {
       // Build the request object
       const project = params.has("project") && params.get("project").length ? params.get("project") : undefined;