Improve validation of hitCondition

Author: isc-bsaviano

src/debug/debugSession.ts

@@ -323,12 +323,12 @@ export class ObjectScriptDebugSession extends LoggingDebugSession {
       await Promise.all(
         xdebugBreakpoints.map(async (breakpoint, index) => {
           try {
-            if (breakpoint.hitCondition && !/^\d+$/.test(breakpoint.hitCondition)) {
-              // The user-defined hitCondition wasn't an integer
+            if (breakpoint.hitCondition && !/^[1-9]\d*$/.test(breakpoint.hitCondition)) {
+              // The user-defined hitCondition wasn't a positive integer
               vscodeBreakpoints[index] = {
                 verified: false,
                 line: breakpoint.line,
-                message: "Hit Count must be an integer",
+                message: "Hit Count must be a positive integer",
               };
             } else {
               await this._connection.sendBreakpointSetCommand(breakpoint);

src/debug/xdebugConnection.ts

@@ -159,7 +159,7 @@ export abstract class Breakpoint {
       this.state = breakpointNode.getAttribute("state") as BreakpointState;
     } else {
       this.type = rest[0];
-      this.hitCondition = rest[1];
+      this.hitCondition = rest[1].trim();
       this.state = "enabled";
     }
   }