Skip to content

Commit 9ffc551

Browse files
committed
Add comments now the workaround has been validated
1 parent 8f6687d commit 9ffc551

File tree

1 file changed

+5
-0
lines changed

1 file changed

+5
-0
lines changed

src/api/index.ts

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -306,6 +306,11 @@ export class AtelierAPI {
306306
const http = this._config.https ? httpsModule : httpModule;
307307
if (!this._agent) {
308308
this._agent = new http.Agent({
309+
/* VS Code 1.93 adopted a version of vscode-proxy-agent that fixed a failure to pass-through the keepAlive option (see https://github.com/microsoft/vscode/issues/173861 and https://github.com/microsoft/vscode-proxy-agent/commit/4eddc930d4fbc6b88ca5557ea7af07d623d390d6)
310+
* This caused poor performance on some operations by our extension (see https://github.com/intersystems-community/vscode-objectscript/issues/1428)
311+
* Short term solution adopted by PR https://github.com/intersystems-community/vscode-objectscript/pull/1432 is not to enable keepAlive
312+
* We should revisit this in the future - TODO
313+
*/
309314
//keepAlive: true,
310315
//maxSockets: 10,
311316
rejectUnauthorized: https && vscode.workspace.getConfiguration("http").get("proxyStrictSSL"),

0 commit comments

Comments
 (0)