Apply suggestions from code review

Co-authored-by: John Murray <[email protected]>

Author: daimor

package.json

@@ -514,7 +514,7 @@
           "properties": {
             "active": {
               "type": "boolean",
-              "description": "This connection is active",
+              "description": "This connection is active.",
               "default": false
             },
             "server": {
@@ -545,7 +545,7 @@
               "maximum": 65535
             },
             "ns": {
-              "description": "Server Namespace",
+              "description": "Server namespace.",
               "type": "string",
               "default": "USER"
             },
@@ -558,29 +558,29 @@
               "description": "Password of username. If not set here it must be provided when connecting."
             },
             "https": {
-              "description": "Use SSL to access to API",
+              "description": "Use SSL to access to API.",
               "type": "boolean",
               "default": false
             },
             "links": {
-              "description": "Extra links for the server",
+              "description": "Extra links for the server.",
               "type": "object"
             },
             "docker-compose": {
               "type": "object",
-              "description": "Connect to server running in docker-compose",
+              "description": "Connect to server running in docker-compose.",
               "additionalProperties": false,
               "properties": {
                 "service": {
-                  "description": "Name of service in docker-compose",
+                  "description": "Name of service in docker-compose.",
                   "type": "string"
                 },
                 "internalPort": {
-                  "description": "Target port inside the service in docker-compose",
+                  "description": "Target port inside the service in docker-compose.",
                   "type": "number"
                 },
                 "file": {
-                  "description": "docker-compose file",
+                  "description": "Name of docker-compose file.",
                   "type": "string"
                 }
               }
@@ -589,7 +589,7 @@
         },
         "objectscript.export": {
           "type": "object",
-          "description": "Export only the necessary stuff",
+          "description": "Export only the necessary stuff.",
           "scope": "resource"
         },
         "objectscript.export.folder": {

src/api/index.ts

@@ -193,7 +193,7 @@ export class AtelierAPI {
       return Promise.reject();
     }
     if (!username || !username.length || !password || !password.length) {
-      outputChannel.appendLine("username and password fields in settinds are mandatory");
+      outputChannel.appendLine("username and password fields in settings are mandatory.");
       return Promise.reject();
     }
     if (minVersion > apiVersion) {

src/commands/serverActions.ts

@@ -15,13 +15,13 @@ export async function serverActions(): Promise<void> {
     actions.push({
       detail: "Enable/Disable current connection",
       id: "toggleConnection",
-      label: "Toggle connection",
+      label: "Toggle Connection",
     });
   }
   if (active) {
     actions.push({
       id: "refreshConnection",
-      label: "Refresh connection",
+      label: "Refresh Connection",
       detail: "Force attempt to connect to the server",
     });
   }
@@ -94,7 +94,7 @@ export async function serverActions(): Promise<void> {
   actions.push({
     detail: classRef,
     id: "openClassReference",
-    label: "Open class reference",
+    label: "Open Class Reference",
   });
   if (!vscode.window.activeTextEditor || vscode.window.activeTextEditor.document.uri.scheme === FILESYSTEM_SCHEMA) {
     actions.push({

src/extension.ts

@@ -168,7 +168,7 @@ export const checkConnection = (clearCookies = false): void => {
     if (withDocker) {
       if (!dockerPort) {
         outputChannel.appendLine(
-          `Something wrong with your docker-compose connection settings. Or your service not running.`
+          `Something is wrong with your docker-compose connection settings, or your service is not running.`
         );
         panel.text = `${packageJson.displayName} - ERROR`;
         return;
@@ -190,7 +190,7 @@ export const checkConnection = (clearCookies = false): void => {
   }
   api = new AtelierAPI(workspaceFolder);
   if (!api.config.host || !api.config.port || !api.config.ns) {
-    outputChannel.appendLine("host, port and ns should be specified");
+    outputChannel.appendLine("host, port and ns must be specified.");
     panel.text = `${packageJson.displayName} - ERROR`;
     return;
   }