Merge pull request #513 from gjsjohnmurray/fix-382

fix #382 do not overwrite a deployed class

Author: gjsjohnmurray

src/commands/compile.ts

@@ -67,6 +67,13 @@ export async function checkChangedOnServer(file: CurrentFile, force = false): Pr
 
 async function importFile(file: CurrentFile, ignoreConflict?: boolean): Promise<any> {
   const api = new AtelierAPI(file.uri);
+  if (file.name.split(".").pop().toLowerCase() === "cls") {
+    const result = await api.actionIndex([file.name]);
+    if (result.result.content[0].content.depl) {
+      vscode.window.showErrorMessage("Cannot import over a deployed class");
+      return Promise.reject();
+    }
+  }
   const content = file.content.split(/\r?\n/);
   const mtime = await checkChangedOnServer(file);
   ignoreConflict = ignoreConflict || mtime < 0 || (file.uri.scheme === "file" && config("overwriteServerChanges"));

src/providers/FileSystemPovider/FileSystemProvider.ts

@@ -193,6 +193,14 @@ export class FileSystemProvider implements vscode.FileSystemProvider {
         // Weirdly, if the file exists on the server we don't actually write its content here.
         // Instead we simply return as though we wrote it successfully.
         // The actual writing is done by our workspace.onDidSaveTextDocument handler.
+        // But first check a case for which we should fail the write and leave the document dirty if changed.
+        if (fileName.split(".").pop().toLowerCase() === "cls") {
+          return api.actionIndex([fileName]).then((result) => {
+            if (result.result.content[0].content.depl) {
+              throw new Error("Cannot overwrite a deployed class");
+            }
+          });
+        }
         return;
       },
       (error) => {