Merge pull request #188 from intersystems-community/servermanager_optional

Make ServerManager extension as optional, do not prevent this extension working.

Author: rajrsingh

package.json

@@ -64,9 +64,6 @@
     "onDebugInitialConfigurations"
   ],
   "main": "./dist/extension",
-  "extensionDependencies": [
-    "intersystems-community.servermanager"
-  ],
   "contributes": {
     "menus": {
       "commandPalette": [
@@ -715,7 +712,12 @@
         "objectscript.studioActionDebugOutput": {
           "type": "boolean",
           "default": false,
-          "description": "Output the action that VSCode should perform as requested by the server in JSON format."
+          "description": "Output the action that VS Code should perform as requested by the server in JSON format."
+        },
+        "objectscript.ignoreInstallServerManager": {
+          "type": "boolean",
+          "default": false,
+          "markdownDescription": "Do not offer to install the [intersystems-community.servermanager](https://marketplace.visualstudio.com/items?itemName=intersystems-community.servermanager) helper extension."
         }
       }
     },

src/extension.ts

@@ -253,6 +253,37 @@ export const checkConnection = (clearCookies = false): void => {
     });
 };
 
+async function serverManager(): Promise<void> {
+  const extId = "intersystems-community.servermanager";
+  const ignore =
+    config("ignoreInstallServerManager") ||
+    vscode.workspace.getConfiguration("intersystems.servers").get("/ignore", false);
+  if (ignore || vscode.extensions.getExtension(extId)) {
+    return;
+  }
+  return vscode.window
+    .showInformationMessage(
+      "The InterSystems® Server Manager extension is recommended to help you define connections.",
+      "Install",
+      "Skip",
+      "Ignore"
+    )
+    .then(async (action) => {
+      switch (action) {
+        case "Install":
+          await vscode.commands.executeCommand("workbench.extensions.search", `@tag:"intersystems"`);
+          await vscode.commands.executeCommand("extension.open", extId);
+          await vscode.commands.executeCommand("workbench.extensions.installExtension", extId);
+          break;
+        case "Ignore":
+          config().update("ignoreInstallServerManager", true, vscode.ConfigurationTarget.Global);
+          break;
+        case "Skip":
+        default:
+      }
+    });
+}
+
 export async function activate(context: vscode.ExtensionContext): Promise<void> {
   if (!packageJson.version.includes("SNAPSHOT")) {
     reporter = new TelemetryReporter(extensionId, extensionVersion, aiKey);
@@ -540,6 +571,9 @@ export async function activate(context: vscode.ExtensionContext): Promise<void>
     ...proposed
   );
   reporter && reporter.sendTelemetryEvent("extensionActivated");
+
+  // offer to install servermanager extension
+  await serverManager();
 }
 
 export function deactivate(): void {

test-fixtures/test.code-workspace

@@ -8,6 +8,7 @@
     "objectscript.conn": {
       "active": false
     },
+    "objectscript.ignoreInstallServerManager": true,
     "intersystems.servers": {
     }
   }