Skip to content

Commit 78604ea

Browse files
authored
Merge pull request #23 from intersystems-community/module-name
getting name from module.xml
2 parents e580218 + 7f8cabf commit 78604ea

File tree

1 file changed

+5
-10
lines changed

1 file changed

+5
-10
lines changed

src/cls/ZPM/Package.cls

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -234,11 +234,6 @@ ClassMethod LoadPackage(Path As %String, repository As %String = "", silent As %
234234
RETURN package.%Save()
235235
}
236236

237-
ClassMethod GetPackageNameFromRepositoryURL(url As %String) As %String
238-
{
239-
Return $PIECE(url, "/", *-1)
240-
}
241-
242237
ClassMethod DownloadPackageFromGitHub(url As %String) As %String
243238
{
244239
SET url = url _ "archive/master.tar.gz"
@@ -307,8 +302,7 @@ ClassMethod UpdatePackage(jo As %DynamicObject) As %Status
307302
#; set url = $ZCONVERT(url, "L")
308303
If $Extract(url, *)'="/" {
309304
Set url = url _ "/"
310-
}
311-
Set name = ..GetPackageNameFromRepositoryURL(url)
305+
}
312306
Set meta = ..GetModuleMeta(url)
313307
If (meta.version = "") { $$$ThrowStatus($$$ERROR(5001, "Invalid package version")) }
314308
If (meta.name = "") { $$$ThrowStatus($$$ERROR(5001, "Package name is empty")) }
@@ -319,13 +313,13 @@ ClassMethod UpdatePackage(jo As %DynamicObject) As %Status
319313
If (..NameVersionExists(meta.name,meta.version)) {
320314
$$$ThrowStatus($$$ERROR(5001, "Version "_meta.version_" of Package "_meta.name_" is already published"))
321315
}
322-
Set sc = ..Publish(url, name)
316+
Set sc = ..Publish(url, meta.name)
323317
}
324318
} Else {
325319
If (..RepositoryExists(url, .id)) {
326320
$$$ThrowStatus($$$ERROR(5001, "This repository was published under a different name"))
327321
} else {
328-
Set sc = ..Publish(url, name)
322+
Set sc = ..Publish(url, meta.name)
329323
}
330324
}
331325
} Catch ex {
@@ -353,7 +347,8 @@ ClassMethod LoadFromGitHub(Url = "")
353347
If $e(Url, *)'="/" {
354348
Set Url = Url _ "/"
355349
}
356-
Set name = ..GetPackageNameFromRepositoryURL(Url)
350+
Set meta = ..GetModuleMeta(Url)
351+
Set name = meta.name
357352
Set outputFolder = ..DownloadPackageFromGitHub(Url)
358353
Set packageFolder = ##class(%File).NormalizeDirectory(name _ "-master", outputFolder)
359354
Set tSC = ..LoadPackage(packageFolder, Url)

0 commit comments

Comments
 (0)