Fix: aggregate viewer now doesn't give divide by zero error when 0 Executed Methods

isc-cge · isc-cge · commit 0e8fde117c67 · 2024-07-12T12:46:37.000-04:00
diff --git a/cls/TestCoverage/UI/AggregateResultViewer.cls b/cls/TestCoverage/UI/AggregateResultViewer.cls
@@ -25,7 +25,7 @@ XData Contents [ XMLNamespace = "http://www.intersystems.com/zen" ]
 				ROUND(100*CoveredLines/ExecutableLines,2) PercentCoverage,
 				ExecutableLines as ExecutableLines,
 				CoveredLines As LinesCovered,
-				ROUND(100*CoveredMethods/ExecutableMethods,2) MethodCoverage,
+				CASE ExecutableMethods WHEN 0 THEN NULL ELSE ROUND(100*CoveredMethods/ExecutableMethods,2) END As MethodCoverage,
 				ExecutableMethods As ExecutableMethods,
 				CoveredMethods As MethodsCovered,
 				'' as Info,
@@ -100,4 +100,3 @@ ClientMethod drawCell(value, row, col) [ Language = javascript ]
 }
 
 }
-

Original file line number	Diff line number	Diff line change
`@@ -25,7 +25,7 @@ XData Contents [ XMLNamespace = "http://www.intersystems.com/zen" ]`
`25`	`25`	`ROUND(100*CoveredLines/ExecutableLines,2) PercentCoverage,`
`26`	`26`	`ExecutableLines as ExecutableLines,`
`27`	`27`	`CoveredLines As LinesCovered,`
`28`		`- ROUND(100*CoveredMethods/ExecutableMethods,2) MethodCoverage,`
	`28`	`+ CASE ExecutableMethods WHEN 0 THEN NULL ELSE ROUND(100*CoveredMethods/ExecutableMethods,2) END As MethodCoverage,`
`29`	`29`	`ExecutableMethods As ExecutableMethods,`
`30`	`30`	`CoveredMethods As MethodsCovered,`
`31`	`31`	`'' as Info,`
`@@ -100,4 +100,3 @@ ClientMethod drawCell(value, row, col) [ Language = javascript ]`
`100`	`100`	`}`
`101`	`101`
`102`	`102`	`}`
`103`		`-`