fix: more defensive coding

isc-tleavitt · isc-tleavitt · commit 0f6af11476f4 · 2024-09-24T14:39:20.000-04:00
Don't try to put 0 in a bitstring
diff --git a/cls/TestCoverage/Procedures.cls b/cls/TestCoverage/Procedures.cls
@@ -82,8 +82,8 @@ ClassMethod ListToBit(pSource As %List) As %Binary [ SqlName = LIST_TO_BIT, SqlP
 	Set tResult = ""
 	Set tPointer = 0
 	While $ListNext(pSource,tPointer,tBitPosition) {
-		If $Data(tBitPosition)#2 && (tBitPosition '= "") {
-			Set $Bit(tResult,tBitPosition) = 1
+		If $Data(tBitPosition)#2 && (+tBitPosition > 0) {
+			Set $Bit(tResult,+tBitPosition) = 1
 		}
 	}
 	Quit tResult

Original file line number	Diff line number	Diff line change
`@@ -82,8 +82,8 @@ ClassMethod ListToBit(pSource As %List) As %Binary [ SqlName = LIST_TO_BIT, SqlP`
`82`	`82`	`Set tResult = ""`
`83`	`83`	`Set tPointer = 0`
`84`	`84`	`While $ListNext(pSource,tPointer,tBitPosition) {`
`85`		`- If $Data(tBitPosition)#2 && (tBitPosition '= "") {`
`86`		`- Set $Bit(tResult,tBitPosition) = 1`
	`85`	`+ If $Data(tBitPosition)#2 && (+tBitPosition > 0) {`
	`86`	`+ Set $Bit(tResult,+tBitPosition) = 1`
`87`	`87`	`}`
`88`	`88`	`}`
`89`	`89`	`Quit tResult`