Skip to content

Commit 9f7b9cb

Browse files
committed
feat: changed the broadcast message type from strig to json
1 parent 9a2da9b commit 9f7b9cb

File tree

3 files changed

+28
-9
lines changed

3 files changed

+28
-9
lines changed

cls/TestCoverage/Listeners/ListenerInterface.cls

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
Class TestCoverage.Listeners.ListenerInterface Extends %RegisteredObject
22
{
33

4-
Method Broadcast(pMessage As %String) As %Status [ Abstract ]
4+
Method Broadcast(pMessage As %DynamicObject) As %Status [ Abstract ]
55
{
66
}
77

cls/TestCoverage/Listeners/ListenerManager.cls

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ Class TestCoverage.Listeners.ListenerManager Extends %RegisteredObject
33

44
Property listeners As list Of TestCoverage.Listeners.ListenerInterface;
55

6-
Method BroadCastToAll(pMessage As %String) As %Status
6+
Method BroadCastToAll(pMessage As %DynamicObject) As %Status
77
{
88
set tSC = $$$OK
99
try {

cls/TestCoverage/Manager.cls

Lines changed: 26 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -643,7 +643,8 @@ ClassMethod OnAfterAllTests(manager As TestCoverage.Manager, dir As %String, ByR
643643
If (manager.CoverageDetail = 0) {
644644
Set tSC = manager.EndCoverageTracking()
645645
if (manager.ListenerManager) {
646-
Do manager.ListenerManager.BroadCastToAll("All tests complete")
646+
set tObj = {"message": "All tests complete"}
647+
Do manager.ListenerManager.BroadCastToAll(tObj)
647648
}
648649
}
649650
Do manager.Monitor.Stop()
@@ -682,7 +683,9 @@ Method OnBeforeTestSuite(dir As %String, suite As %String, testspec As %String,
682683
Set ..CurrentTestClass = ""
683684
Set ..CurrentTestMethod = ""
684685
if (..ListenerManager) {
685-
Do ..ListenerManager.BroadCastToAll("Starting test suite: " _ suite )
686+
set tObj = {"message": "Starting test suite: "}
687+
do tObj.%Set("suite", suite)
688+
Do ..ListenerManager.BroadCastToAll(tObj)
686689
}
687690
If (..CoverageDetail = 1) {
688691
Set tSC = ..StartCoverageTracking()
@@ -705,7 +708,9 @@ Method OnAfterTestSuite(dir As %String, suite As %String, testspec As %String, B
705708
Set tSC = ..EndCoverageTracking($Case(suite,"":"(root)",:suite))
706709
}
707710
if (..ListenerManager) {
708-
Do ..ListenerManager.BroadCastToAll("Finished test suite: " _ suite )
711+
set tObj = {"message": "Finished test suite: "}
712+
do tObj.%Set("suite", suite)
713+
Do ..ListenerManager.BroadCastToAll(tObj)
709714
}
710715
} Catch e {
711716
Set tSC = e.AsStatus()
@@ -722,7 +727,10 @@ Method OnBeforeTestCase(suite As %String, class As %String) As %Status
722727
Set ..CurrentTestClass = class
723728
Set ..CurrentTestMethod = ""
724729
if (..ListenerManager) {
725-
Do ..ListenerManager.BroadCastToAll("Starting test case: " _ suite _ "/" _ class )
730+
set tObj = {"message": "Starting test case: "}
731+
do tObj.%Set("suite", suite)
732+
do tObj.%Set("class", class)
733+
Do ..ListenerManager.BroadCastToAll(tObj)
726734
}
727735
If (..CoverageDetail = 2) {
728736
Set tSC = ..StartCoverageTracking()
@@ -743,7 +751,10 @@ Method OnAfterTestCase(suite As %String, class As %String) As %Status
743751
Set tSC = ..EndCoverageTracking(suite, class)
744752
}
745753
if (..ListenerManager) {
746-
Do ..ListenerManager.BroadCastToAll("Starting test case: " _ suite _ "/" _ class )
754+
set tObj = {"message": "Finished test case: "}
755+
do tObj.%Set("suite", suite)
756+
do tObj.%Set("class", class)
757+
Do ..ListenerManager.BroadCastToAll(tObj)
747758
}
748759
} Catch e {
749760
Set tSC = e.AsStatus()
@@ -759,7 +770,11 @@ Method OnBeforeOneTest(suite As %String, class As %String, method As %String) As
759770
Try {
760771
Set ..CurrentTestMethod = method
761772
if (..ListenerManager) {
762-
Do ..ListenerManager.BroadCastToAll("Starting test method: " _ suite _ "/" _ class _ "/" _ method )
773+
set tObj = {"message": "Starting test method: "}
774+
do tObj.%Set("suite", suite)
775+
do tObj.%Set("class", class)
776+
do tObj.%Set("method", method)
777+
Do ..ListenerManager.BroadCastToAll(tObj)
763778
}
764779
If (..CoverageDetail = 3) {
765780
Set tSC = ..StartCoverageTracking()
@@ -780,7 +795,11 @@ Method OnAfterOneTest(suite As %String, class As %String, method As %String) As
780795
Set tSC = ..EndCoverageTracking(suite, class, method)
781796
}
782797
if (..ListenerManager) {
783-
Do ..ListenerManager.BroadCastToAll("Finished test method: " _ suite _ "/" _ class _ "/" _ method )
798+
set tObj = {"message": "Finished test method: "}
799+
do tObj.%Set("suite", suite)
800+
do tObj.%Set("class", class)
801+
do tObj.%Set("method", method)
802+
Do ..ListenerManager.BroadCastToAll(tObj)
784803
}
785804
} Catch e {
786805
Set tSC = e.AsStatus()

0 commit comments

Comments
 (0)