Was failing the CI tests on github, maybe the issue is that extra in LogAssert is passed in by reference?

isc-cge · isc-cge · commit ff5a91153f5a · 2024-06-24T17:09:51.000-04:00
diff --git a/cls/TestCoverage/Manager.cls b/cls/TestCoverage/Manager.cls
@@ -178,10 +178,10 @@ Method CoverageTargetsSet(%value) As %Status [ Internal, Private ]
 	Quit $$$OK
 }
 
-Method LogAssert(success, action, description, extra, location)
+Method LogAssert(success, action, description, ByRef extra, location)
 {
 	set ^IRIS.TEMPCG($i(^IRIS.TEMPCG)) = "We're in LogAssert"
-	do ##super(success, action, description, extra, location)
+	do ##super(success, action, description, .extra, location)
 	if (..InteroperabilityProcesses) {
 		// Collect the list of PIDs used by Interoperability processes in the current namespace
 		// Run unit tests collecting coverage in that specific list of processes (plus the current process)

Original file line number	Diff line number	Diff line change
`@@ -178,10 +178,10 @@ Method CoverageTargetsSet(%value) As %Status [ Internal, Private ]`
`178`	`178`	`Quit $$$OK`
`179`	`179`	`}`
`180`	`180`
`181`		`-Method LogAssert(success, action, description, extra, location)`
	`181`	`+Method LogAssert(success, action, description, ByRef extra, location)`
`182`	`182`	`{`
`183`	`183`	`set ^IRIS.TEMPCG($i(^IRIS.TEMPCG)) = "We're in LogAssert"`
`184`		`- do ##super(success, action, description, extra, location)`
	`184`	`+ do ##super(success, action, description, .extra, location)`
`185`	`185`	`if (..InteroperabilityProcesses) {`
`186`	`186`	`// Collect the list of PIDs used by Interoperability processes in the current namespace`
`187`	`187`	`// Run unit tests collecting coverage in that specific list of processes (plus the current process)`