Fix raised issues

isc-etamarch · isc-etamarch · commit 4ee0b3e8ab7b · 2024-10-09T09:18:49.000-04:00
Set environment lobal through method, default environment name to empty
diff --git a/cls/SourceControl/Git/Settings.cls b/cls/SourceControl/Git/Settings.cls
@@ -120,7 +120,7 @@ Method %Save() As %Status
         set @storage@("settings", "user", $username, "basicMode") = ..basicMode
     } 
 
-    set ^%SYS("SystemMode") = ..environmentName
+    do $SYSTEM.Version.SystemMode(..environmentName)
     
 
     // update value of basicUserMode to reflect the updated setting for basicMode
diff --git a/cls/SourceControl/Git/Utils.cls b/cls/SourceControl/Git/Utils.cls
@@ -165,7 +165,7 @@ ClassMethod WarnInstanceWideUncommitted() As %Boolean
 
 ClassMethod EnvironmentName() As %String
 {
-    quit $get(@..#Storage@("settings","environmentName"),1)
+    quit $get(@..#Storage@("settings","environmentName"),"")
 }
 
 ClassMethod IsLIVE() As %Boolean

Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ Method %Save() As %Status`
`120`	`120`	`set @storage@("settings", "user", $username, "basicMode") = ..basicMode`
`121`	`121`	`}`
`122`	`122`
`123`		`- set ^%SYS("SystemMode") = ..environmentName`
	`123`	`+ do $SYSTEM.Version.SystemMode(..environmentName)`
`124`	`124`
`125`	`125`
`126`	`126`	`// update value of basicUserMode to reflect the updated setting for basicMode`
Original file line number	Diff line number	Diff line change
`@@ -165,7 +165,7 @@ ClassMethod WarnInstanceWideUncommitted() As %Boolean`
`165`	`165`
`166`	`166`	`ClassMethod EnvironmentName() As %String`
`167`	`167`	`{`
`168`		`- quit $get(@..#Storage@("settings","environmentName"),1)`
	`168`	`+ quit $get(@..#Storage@("settings","environmentName"),"")`
`169`	`169`	`}`
`170`	`170`
`171`	`171`	`ClassMethod IsLIVE() As %Boolean`