Skip to content

Commit 61f707a

Browse files
authored
If the branch is already up-to-date then a proper message is displayed (#94)
1 parent 40f32c3 commit 61f707a

File tree

2 files changed

+16
-6
lines changed

2 files changed

+16
-6
lines changed

git-webui/release/share/git-webui/webui/js/git-webui.js

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2102,6 +2102,12 @@ $(function () {
21022102

21032103
});
21042104

2105+
function upToDateHandler(message){
2106+
if(message.includes("Already up to date.")) {
2107+
webui.showSuccess(message);
2108+
}
2109+
}
2110+
21052111
$(document).on('click', '.btn-merge-branch', function(e){
21062112
e.preventDefault();
21072113
var refName = $(this).parent().parent().parent().siblings(
@@ -2121,7 +2127,7 @@ $(function () {
21212127
webui.showError(message);
21222128
}
21232129
}
2124-
webui.git("merge --no-commit --no-ff "+refName, "", "", testMergeHandler, testMergeHandler);
2130+
webui.git("merge --no-commit --no-ff "+refName, "", upToDateHandler, testMergeHandler, testMergeHandler);
21252131
});
21262132

21272133
$(document).on('click', '.btn-merge-remote-branch', function(e){
@@ -2138,7 +2144,6 @@ $(function () {
21382144
function suppressErrorMessage(error) {
21392145
}
21402146
webui.git("merge --abort", "", "", suppressErrorMessage);
2141-
21422147
if(message.includes("Automatic merge went well") || message.includes("Auto-merging ")){
21432148
webui.git("merge "+refName, function (output){
21442149
webui.showSuccess(output);
@@ -2148,7 +2153,7 @@ $(function () {
21482153
webui.showError(message);
21492154
}
21502155
}
2151-
webui.git("merge --no-commit --no-ff "+refName, "", "", testMergeHandler, testMergeHandler);
2156+
webui.git("merge --no-commit --no-ff "+refName, "", upToDateHandler, testMergeHandler, testMergeHandler);
21522157
});
21532158

21542159
$(document).on('click', '.btn-checkout-remote-branch', function(e) {

git-webui/src/share/git-webui/webui/js/git-webui.js

Lines changed: 8 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2102,6 +2102,12 @@ $(function () {
21022102

21032103
});
21042104

2105+
function upToDateHandler(message){
2106+
if(message.includes("Already up to date.")) {
2107+
webui.showSuccess(message);
2108+
}
2109+
}
2110+
21052111
$(document).on('click', '.btn-merge-branch', function(e){
21062112
e.preventDefault();
21072113
var refName = $(this).parent().parent().parent().siblings(
@@ -2121,7 +2127,7 @@ $(function () {
21212127
webui.showError(message);
21222128
}
21232129
}
2124-
webui.git("merge --no-commit --no-ff "+refName, "", "", testMergeHandler, testMergeHandler);
2130+
webui.git("merge --no-commit --no-ff "+refName, "", upToDateHandler, testMergeHandler, testMergeHandler);
21252131
});
21262132

21272133
$(document).on('click', '.btn-merge-remote-branch', function(e){
@@ -2138,7 +2144,6 @@ $(function () {
21382144
function suppressErrorMessage(error) {
21392145
}
21402146
webui.git("merge --abort", "", "", suppressErrorMessage);
2141-
21422147
if(message.includes("Automatic merge went well") || message.includes("Auto-merging ")){
21432148
webui.git("merge "+refName, function (output){
21442149
webui.showSuccess(output);
@@ -2148,7 +2153,7 @@ $(function () {
21482153
webui.showError(message);
21492154
}
21502155
}
2151-
webui.git("merge --no-commit --no-ff "+refName, "", "", testMergeHandler, testMergeHandler);
2156+
webui.git("merge --no-commit --no-ff "+refName, "", upToDateHandler, testMergeHandler, testMergeHandler);
21522157
});
21532158

21542159
$(document).on('click', '.btn-checkout-remote-branch', function(e) {

0 commit comments

Comments
 (0)