Skip to content

Commit e1cb97f

Browse files
authored
Merge pull request #420 from intersystems/disallow-add-uncompiled
disallows the user from choosing the add menu option on an uncompiled file
2 parents d2d96a1 + 0d00072 commit e1cb97f

File tree

2 files changed

+7
-1
lines changed

2 files changed

+7
-1
lines changed

CHANGELOG.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
99

1010
### Fixed
1111
- Fixed JS errors in Studio on certain operations (#416)
12+
- Add menu option disabled for unsaved files (#420)
1213
- Fixed issue where selecting different item in stash list didn't update diff view (#265)
1314
- Tooltip in workspace now shows user who made uncommitted change if not current user (#411)
1415
- Files are added to source control upon creation properly (#404)

cls/SourceControl/Git/Extension.cls

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -191,7 +191,12 @@ Method OnSourceMenuContextItem(itemName As %String, menuItemName As %String, ByR
191191
} elseif ##class(SourceControl.Git.Utils).IsInSourceControl(itemName) {
192192
set Enabled = $case(menuItemName, "AddToSC":-1,:1)
193193
} else {
194-
set Enabled = $case(menuItemName, "AddToSC":1,:-1)
194+
if (##class(SourceControl.Git.Utils).Type(itemName) = "cls") && ('$$$defClassDefined($extract(itemName, 1, $length(itemName) - 4))) {
195+
set Enabled = -1
196+
} else {
197+
set Enabled = $case(menuItemName, "AddToSC":1,:-1)
198+
}
199+
195200
}
196201
if (menuItemName '= "") {
197202
set DisplayName = ..LocalizeName(menuItemName)

0 commit comments

Comments
 (0)