Merge pull request #757 from intersystems/really-fix-favorites

isc-tleavitt · web-flow · commit ebac90f2d87d · 2025-04-23T14:49:46.000-04:00
Git links in favorites now actually work
diff --git a/cls/SourceControl/Git/Utils.cls b/cls/SourceControl/Git/Utils.cls
@@ -2685,8 +2685,8 @@ ClassMethod ConfigureWeb()
     new $Namespace
     set $Namespace = "%SYS"
     write !,"Adding favorites for all users:"
-    set sql = "insert or update into %SYS_Portal.Users (Username, Page, Data) "_
-        "select ID,?,$LISTBUILD(?) from Security.Users"
+    set sql = "insert or update %NOCHECK into %SYS_Portal.Users (Username, Page, Data) "_
+        "select ID,?,? from Security.Users"
     set caption = "Git: "_installNamespace
     set link = "/isc/studio/usertemplates/gitsourcecontrol/webuidriver.csp/"_installNamespace_"/"
     write !,"Adding Git favorite... "
@@ -3182,3 +3182,4 @@ ClassMethod GitUnstage(Output output As %Library.DynamicObject) As %Status
 }
 
 }
+

Original file line number	Diff line number	Diff line change
`@@ -2685,8 +2685,8 @@ ClassMethod ConfigureWeb()`
`2685`	`2685`	`new $Namespace`
`2686`	`2686`	`set $Namespace = "%SYS"`
`2687`	`2687`	`write !,"Adding favorites for all users:"`
`2688`		`- set sql = "insert or update into %SYS_Portal.Users (Username, Page, Data) "_`
`2689`		`- "select ID,?,$LISTBUILD(?) from Security.Users"`
	`2688`	`+ set sql = "insert or update %NOCHECK into %SYS_Portal.Users (Username, Page, Data) "_`
	`2689`	`+ "select ID,?,? from Security.Users"`
`2690`	`2690`	`set caption = "Git: "_installNamespace`
`2691`	`2691`	`set link = "/isc/studio/usertemplates/gitsourcecontrol/webuidriver.csp/"_installNamespace_"/"`
`2692`	`2692`	`write !,"Adding Git favorite... "`
`@@ -3182,3 +3182,4 @@ ClassMethod GitUnstage(Output output As %Library.DynamicObject) As %Status`
`3182`	`3182`	`}`
`3183`	`3183`
`3184`	`3184`	`}`
	`3185`	`+`