Allow favorites changing for all users

Author: isc-etamarch

CHANGELOG.md

@@ -48,6 +48,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Fixed sending OS error when git pull encounters error (#545)
 - Fixed suppressing editing of locked classes (#301)
 - Fixed importing CSP files (#251)
+- Fixed changing favorites for users without permissions (#587)
 
 ## [2.6.0] - 2024-10-07
 

cls/SourceControl/Git/Settings.cls

@@ -136,7 +136,7 @@ Method %Save() As %Status
     kill @##class(SourceControl.Git.Utils).MappingsNode()
     merge @##class(SourceControl.Git.Utils).MappingsNode() = ..Mappings
 
-    do ##class(SourceControl.Git.Utils).ConfigureFavoriteNamespaces($username, ..favoriteNamespaces)
+    do ##class(%zpkg.isc.sc.git.Favorites).ConfigureFavoriteNamespaces($username, ..favoriteNamespaces)
 
     quit $$$OK
 }

cls/SourceControl/Git/Utils.cls

@@ -75,7 +75,7 @@ $Get(@..#Storage@("settings","settingsUIReadOnly"), 0)
 ClassMethod FavoriteNamespaces() As %String
 {
     set favNamespaces = []
-    do ..GetFavoriteNamespaces(.favNamespaces,[])
+    do ##class(%zpkg.isc.sc.git.Favorites).GetFavoriteNamespaces(.favNamespaces,[])
     return favNamespaces
 }
 
@@ -612,7 +612,7 @@ ClassMethod GetCurrentRevision() As %String
     quit revision
 }
 
-ClassMethod Pull(remote As %String = "origin", pTerminateOnError As %Boolean=0) As %Status
+ClassMethod Pull(remote As %String = "origin", pTerminateOnError As %Boolean = 0) As %Status
 {
     New %gitSCOutputFlag
     Set %gitSCOutputFlag = 1
@@ -2985,4 +2985,3 @@ ClassMethod GetFavoriteNamespaces(ByRef favNamespaces As %DynamicArray, ByRef no
 }
 
 }
-

cls/_zpkg/isc/sc/git/Favorites.cls

@@ -0,0 +1,55 @@
+Class %zpkg.isc.sc.git.Favorites Extends %RegisteredObject
+{
+    ClassMethod ConfigureFavoriteNamespaces(username As %String, newNamespaces As %String)
+{
+    $$$AddAllRoleTemporary
+    // Delete all the GIT favorite links for the user 
+    &sql(DELETE FROM %SYS_Portal.Users WHERE Username = :username AND Page LIKE '%Git%')
+
+    set iterator = newNamespaces.%GetIterator()
+    while iterator.%GetNext(.key, .value) {
+        set installNamespace = value
+        
+        // Insert Git link
+        set caption = "Git: " _ installNamespace
+        set link = "/isc/studio/usertemplates/gitsourcecontrol/webuidriver.csp/" _ installNamespace _ "/"
+        &sql(INSERT OR UPDATE INTO %SYS_Portal.Users (Username, Page, Data) VALUES (:username, :caption, :link))
+        
+        // Insert Git Pull link
+        set caption = "Git Pull: " _ installNamespace
+        set link = "/isc/studio/usertemplates/gitsourcecontrol/pull.csp?$NAMESPACE=" _ installNamespace
+        &sql(INSERT OR UPDATE INTO %SYS_Portal.Users (Username, Page, Data) VALUES (:username, :caption, :link))
+    }
+}
+
+ClassMethod GetFavoriteNamespaces(ByRef favNamespaces As %DynamicArray, ByRef nonFavNamespaces As %DynamicArray)
+{
+    $$$AddAllRoleTemporary
+    set allNamespaces = ##class(SourceControl.Git.Utils).GetContexts(1)
+    set iterator = allNamespaces.%GetIterator()
+
+    set username = $USERNAME
+    set pagePrefix = "Git:"    
+    &sql(DECLARE FavCursor CURSOR FOR SELECT Page into :page from %SYS_Portal.Users where username = :username and page %STARTSWITH :pagePrefix)
+
+    while iterator.%GetNext(.key, .value) {
+        set foundFlag = 0
+        &sql(OPEN FavCursor)
+        throw:SQLCODE<0 ##class(%Exception.SQL).CreateFromSQLCODE(SQLCODE, %msg)
+        &sql(FETCH FavCursor)
+        while (SQLCODE = 0) {
+            set pageValue = "Git: "_value 
+            if (page = pageValue) {
+                do favNamespaces.%Push(value)
+                set foundFlag = 1
+            }
+            &sql(FETCH FavCursor)
+        }
+        &sql(CLOSE FavCursor)
+
+        if ('foundFlag) {
+            do nonFavNamespaces.%Push(value)
+        }
+    }
+}
+}

csp/gitprojectsettings.csp

@@ -614,7 +614,7 @@ body {
                 <server>
                     set nonFavNamespaces = []
                     set selectedNamespaces = []
-                    do ##class(SourceControl.Git.Utils).GetFavoriteNamespaces(.selectedNamespaces,.nonFavNamespaces)
+                    do ##class(%zpkg.isc.sc.git.Favorites).GetFavoriteNamespaces(.selectedNamespaces,.nonFavNamespaces)
                     set iterator = selectedNamespaces.%GetIterator()
                     while iterator.%GetNext(.key, .value) {
                         &html<<option selected value=#(value)#>#(value)#</option>>