Terminate git pull on error

Author: isc-etamarch

CHANGELOG.md

@@ -30,6 +30,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Make sure more fetch calls prune the remote branches (#471)
 - Force export of item if it has been modified (#354)
 - Production configuration page no longer closes Sync/WebUI when operations there change the production (#542)
+- Fixed sending OS error when git pull encounters error (#545)
 
 ## [2.6.0] - 2024-10-07
 

cls/SourceControl/Git/API.cls

@@ -44,9 +44,9 @@ ClassMethod Configure()
 }
 
 /// API for git pull - just wraps Utils
-ClassMethod Pull()
+ClassMethod Pull(terminateOnError As %Boolean = 0)
 {
-    quit ##class(SourceControl.Git.Utils).Pull()
+    quit ##class(SourceControl.Git.Utils).Pull(,terminateOnError)
 }
 
 /// Locks the environment to prevent changes to code other than through git pull.

cls/SourceControl/Git/Utils.cls

@@ -610,7 +610,7 @@ ClassMethod GetCurrentRevision() As %String
     quit revision
 }
 
-ClassMethod Pull(remote As %String = "origin") As %Status
+ClassMethod Pull(remote As %String = "origin", terminateOnError As %Boolean=0) As %Status
 {
     New %gitSCOutputFlag
     Set %gitSCOutputFlag = 1
@@ -625,6 +625,10 @@ ClassMethod Pull(remote As %String = "origin") As %Status
     write !
     do errStream.OutputToDevice()
     write !, "Pull ran with return code: " _ returnCode
+    set err = errStream.Read()
+    if $find(err,"error") && terminateOnError {
+        quit $$$Error($$$GeneralError, err)
+    }
     quit $$$OK
 }