Publishing a module with python dependencies #1021
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isc-jlechtne
requested review from
isc-dchui,
isc-egabhart,
isc-eneil,
isc-jili,
isc-kiyer,
isc-pbarton and
isc-tleavitt
as code owners
isc-jili
requested changes
Jan 6, 2026
Collaborator
isc-jili
left a comment
isc-jili
left a comment
There was a problem hiding this comment.
Changes look good! Thanks for fixing this.
Would it be good to add some tests for the publish command with "export-python-deps"? As well as add/edit test cases that demonstrate the previously buggy behavior that were not caught by previous existing tests?
Collaborator
|
Agreed that some tests would be good. Also maybe rename the PR to something more informative? |
isc-jlechtne
changed the title
added 2 commits
January 8, 2026 14:56
isc-eneil
previously approved these changes
Jan 9, 2026
isc-kiyer
reviewed
Jan 10, 2026
src/cls/IPM/Lifecycle/Base.cls
Outdated
| do ..ExportSingleModule(.tSingleModuleArray, pTargetDirectory, .pDependencyGraph, .tParams, tVerbose) | ||
| } | ||
|
|
||
| set exportPythonDependencies = $get(pParams("ExportPythonDependencies"), 0) |
Collaborator
There was a problem hiding this comment.
@isc-jlechtne Does this ensure python dependencies of dependent modules are also exported? It doesn't seem to and only seems to do it for the base module?
isc-jili
requested changes
Jan 12, 2026
| do $$$AssertStatusOK(sc, "Removed local filesystem repo") | ||
| set sc = ##class(%IPM.Main).Shell("repo -delete -n remote") | ||
| do $$$AssertStatusOK(sc, "Removed remote repo") | ||
| } |
Collaborator
There was a problem hiding this comment.
Suggestion to add a test case asserting that wheels are:
- bundled into the published artifact, and
- absent when the flag is omitted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #1024 as well as adding the
-export-python-depsflag to the "publish" command