Skip to content

Commit 6075573

Browse files
author
Jakub Kulhan
committed
autoupdated protocol.json & generated files
1 parent 061e92e commit 6075573

File tree

4 files changed

+24
-5
lines changed

4 files changed

+24
-5
lines changed

gen-src/ChromeDevtoolsProtocol/Domain/PageDomainInterface.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ public function generateTestReport(ContextInterface $ctx, GenerateTestReportRequ
284284

285285

286286
/**
287-
* Returns the unique (PWA) app id.
287+
* Returns the unique (PWA) app id. Only returns values if the feature flag 'WebAppEnableManifestId' is enabled
288288
*
289289
* @param ContextInterface $ctx
290290
*

gen-src/ChromeDevtoolsProtocol/Model/Page/GetAppIdResponse.php

Lines changed: 14 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,19 +12,29 @@
1212
final class GetAppIdResponse implements \JsonSerializable
1313
{
1414
/**
15-
* Only returns a value if the feature flag 'WebAppEnableManifestId' is enabled
15+
* App id, either from manifest's id attribute or computed from start_url
1616
*
1717
* @var string|null
1818
*/
1919
public $appId;
2020

21+
/**
22+
* Recommendation for manifest's id attribute to match current id computed from start_url
23+
*
24+
* @var string|null
25+
*/
26+
public $recommendedId;
27+
2128

2229
public static function fromJson($data)
2330
{
2431
$instance = new static();
2532
if (isset($data->appId)) {
2633
$instance->appId = (string)$data->appId;
2734
}
35+
if (isset($data->recommendedId)) {
36+
$instance->recommendedId = (string)$data->recommendedId;
37+
}
2838
return $instance;
2939
}
3040

@@ -35,6 +45,9 @@ public function jsonSerialize()
3545
if ($this->appId !== null) {
3646
$data->appId = $this->appId;
3747
}
48+
if ($this->recommendedId !== null) {
49+
$data->recommendedId = $this->recommendedId;
50+
}
3851
return $data;
3952
}
4053
}

protocol.json

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18032,12 +18032,18 @@
1803218032
},
1803318033
{
1803418034
"name": "getAppId",
18035-
"description": "Returns the unique (PWA) app id.",
18035+
"description": "Returns the unique (PWA) app id. Only returns values if the feature flag 'WebAppEnableManifestId' is enabled",
1803618036
"experimental": true,
1803718037
"returns": [
1803818038
{
1803918039
"name": "appId",
18040-
"description": "Only returns a value if the feature flag 'WebAppEnableManifestId' is enabled",
18040+
"description": "App id, either from manifest's id attribute or computed from start_url",
18041+
"optional": true,
18042+
"type": "string"
18043+
},
18044+
{
18045+
"name": "recommendedId",
18046+
"description": "Recommendation for manifest's id attribute to match current id computed from start_url",
1804118047
"optional": true,
1804218048
"type": "string"
1804318049
}

protocol.json.md5

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
8522f545d35f62e6430c9c99f7c3f331 protocol.json
1+
3da84ff5c6460ad3bc90da6a5d1665ef protocol.json

0 commit comments

Comments
 (0)