Merge pull request #38 from intive-FDV/fix/person_detail

Fix Person error layout when there isn't data.

Author: urielgarridointive

app/src/main/java/com/intive/tmdbandroid/details/ui/person/adapter/CombinedCreditsAdapter.kt

@@ -5,6 +5,7 @@ import android.view.ViewGroup
 import androidx.recyclerview.widget.DiffUtil
 import androidx.recyclerview.widget.ListAdapter
 import androidx.recyclerview.widget.RecyclerView
+import androidx.swiperefreshlayout.widget.CircularProgressDrawable
 import com.bumptech.glide.Glide
 import com.bumptech.glide.request.RequestOptions
 import com.intive.tmdbandroid.R
@@ -42,9 +43,15 @@ class CombinedCreditsAdapter(
                 clickListener.invoke(item)
             }
 
+            val circularProgressDrawable = CircularProgressDrawable(itemView.context).apply {
+                strokeWidth = 5f
+                centerRadius = 25f
+            }
+            circularProgressDrawable.start()
+
             val options = RequestOptions()
                 .centerCrop()
-                .placeholder(R.drawable.ic_image)
+                .placeholder(circularProgressDrawable)
                 .error(R.drawable.ic_image)
 
             val backdropURL = imgUrl + item.backdrop_path

app/src/main/java/com/intive/tmdbandroid/details/ui/person/ui/DetailPersonFragment.kt

@@ -5,7 +5,6 @@ import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
 import androidx.appcompat.content.res.AppCompatResources
-import androidx.core.content.ContextCompat
 import androidx.core.view.isVisible
 import androidx.fragment.app.Fragment
 import androidx.fragment.app.viewModels
@@ -110,7 +109,7 @@ class DetailPersonFragment : Fragment() {
                     is State.Success -> {
                         binding.layoutLoadingDetail.root.isVisible = false
                         binding.coordinatorContainerDetail.isVisible = true
-                        setupUICombineCredits(binding, state.data)
+                        setupUICombineCredits(state.data)
                     }
                 }
             }
@@ -144,23 +143,15 @@ class DetailPersonFragment : Fragment() {
         }
     }
 
-    private fun setupUICombineCredits(
-        binding: FragmentDetailPersonBinding,
-        screenings: List<Screening>
-    ) {
-        if (screenings.isNotEmpty())
-            combinedCreditsAdapter.submitList(screenings)
-        else {
-            binding.layoutErrorDetail.root.isVisible = true
-        }
+    private fun setupUICombineCredits(screenings: List<Screening>) {
+        combinedCreditsAdapter.submitList(screenings)
     }
 
     private fun setupUIDetailPerson(
         binding: FragmentDetailPersonBinding,
         resultPerson: ResultPerson
     ) {
         setImage(resultPerson.profile_path, binding)
-        setPopularity(resultPerson.popularity, binding)
         setToolbar(resultPerson.name, binding)
         setBiography(resultPerson.biography, binding)
     }
@@ -181,29 +172,6 @@ class DetailPersonFragment : Fragment() {
             .into(binding.imageDetailImageView)
     }
 
-    private fun setPopularity(
-        popularity: Double,
-        binding: FragmentDetailPersonBinding
-    ) {
-        val percentage = (popularity * 10).toInt()
-
-        binding.popularityRatingNumber.text =
-            requireContext().resources.getString(R.string.popularity, percentage)
-
-        val context = binding.root.context
-
-        when {
-            percentage < 25 -> binding.popularityThumbIcon.imageTintList =
-                ContextCompat.getColorStateList(context, R.color.red)
-            percentage < 45 -> binding.popularityThumbIcon.imageTintList =
-                ContextCompat.getColorStateList(context, R.color.orange)
-            percentage < 75 -> binding.popularityThumbIcon.imageTintList =
-                ContextCompat.getColorStateList(context, R.color.yellow)
-            else -> binding.popularityThumbIcon.imageTintList =
-                ContextCompat.getColorStateList(context, R.color.green)
-        }
-    }
-
     private fun setToolbar(name: String, binding: FragmentDetailPersonBinding) {
         val navController = findNavController()
         val appBarConfiguration = AppBarConfiguration(navController.graph)

app/src/main/java/com/intive/tmdbandroid/entity/ResultPerson.kt

@@ -3,6 +3,5 @@ package com.intive.tmdbandroid.entity
 data class ResultPerson(
     val name: String,
     val biography: String,
-    val popularity: Double,
     val profile_path: String?
 )

app/src/main/res/layout/fragment_detail_person.xml

@@ -66,49 +66,24 @@
                 android:layout_height="wrap_content"
                 android:layout_margin="16dp">
 
-                <ImageView
-                    android:id="@+id/popularity_thumb_icon"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:contentDescription="@string/thumb_description"
-                    android:src="@drawable/ic_thumb_up"
-                    app:layout_constraintStart_toStartOf="parent"
-                    app:layout_constraintTop_toTopOf="parent"
-                    app:tint="@color/red" />
-
-                <TextView
-                    android:id="@+id/popularity_rating_number"
-                    android:layout_width="wrap_content"
-                    android:layout_height="wrap_content"
-                    android:layout_marginStart="12dp"
-                    android:textColor="@color/material_on_background_emphasis_high_type"
-                    android:textSize="20sp"
-                    android:textStyle="bold"
-                    app:layout_constraintBottom_toBottomOf="@+id/popularity_thumb_icon"
-                    app:layout_constraintStart_toEndOf="@id/popularity_thumb_icon"
-                    app:layout_constraintTop_toTopOf="@id/popularity_thumb_icon"
-                    tools:text="23%" />
-
                 <TextView
                     android:id="@+id/biography_textView"
                     android:layout_width="wrap_content"
                     android:layout_height="wrap_content"
-                    android:layout_marginTop="32dp"
                     android:text="@string/biography"
-                    android:textColor="@color/material_on_background_emphasis_high_type"
+                    android:textColor="@color/black"
                     android:textSize="20sp"
                     android:textStyle="bold"
                     app:layout_constraintStart_toStartOf="parent"
-                    app:layout_constraintTop_toBottomOf="@+id/popularity_rating_number" />
-
+                    app:layout_constraintTop_toTopOf="parent"/>
                 <TextView
                     android:id="@+id/biography_detail_textView"
                     android:layout_width="match_parent"
                     android:layout_height="wrap_content"
                     android:layout_marginVertical="20dp"
                     android:layout_marginTop="8dp"
                     android:lineSpacingExtra="4dp"
-                    android:textColor="@color/material_on_background_emphasis_high_type"
+                    android:textColor="@color/black"
                     android:textSize="16sp"
                     app:layout_constraintStart_toStartOf="parent"
                     app:layout_constraintTop_toBottomOf="@id/biography_textView"