Skip to content

Commit 7b3437a

Browse files
committed
👕 refactor(eslint): docs linting
1 parent d6f08ea commit 7b3437a

File tree

8 files changed

+264
-26
lines changed

8 files changed

+264
-26
lines changed

docs/.eslintrc.js

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
'use strict'
2+
3+
module.exports = {
4+
extends: '../.eslintrc.js',
5+
plugins: [
6+
'markdown'
7+
]
8+
}

docs/rules/no-dynamic-keys.md

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,9 @@ localization codes:
3939
```
4040

4141
```js
42+
import Vue from 'vue'
43+
import VueI18n from 'vue-i18n'
44+
4245
const i18n = new VueI18n({
4346
locale: 'en',
4447
messages: {
@@ -71,23 +74,26 @@ localization codes:
7174
```vue
7275
<template>
7376
<div class="app">
74-
<!-- GOOD -->
77+
<!-- GOOD -->
7578
<p>{{ $t('hello') }}</p>
76-
<!-- GOOD -->
79+
<!-- GOOD -->
7780
<p v-t="'hello'"></p>
7881
</div>
7982
</template>
8083
```
8184

8285
```js
86+
import Vue from 'vue'
87+
import VueI18n from 'vue-i18n'
88+
8389
const i18n = new VueI18n({
8490
locale: 'en',
8591
messages: {
8692
en: require('./locales/en.json')
8793
}
8894
})
8995

90-
const app = new Vue({
96+
new Vue({
9197
i18n,
9298
data () {
9399
return { msg: 'hello' }

docs/rules/no-html-messages.md

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ This rule is aimed at eliminating HTML localization messages.
1313
:-1: Examples of **incorrect** code for this rule:
1414

1515
locale messages:
16-
```js
16+
```json
1717
// ✗ BAD
1818
{
1919
"hello": "Hello! DIO!",
@@ -40,6 +40,9 @@ In localization codes of application:
4040
```
4141

4242
```js
43+
import Vue from 'vue'
44+
import VueI18n from 'vue-i18n'
45+
4346
const i18n = new VueI18n({
4447
locale: 'en',
4548
messages: {
@@ -48,15 +51,15 @@ const i18n = new VueI18n({
4851
})
4952

5053
new Vue({
51-
i18n,
54+
i18n
5255
// ...
5356
}).$mount('#app')
5457
```
5558

5659
:+1: Examples of **correct** code for this rule:
5760

5861
locale messages:
59-
```js
62+
```json
6063
// ✓ GOOD
6164
{
6265
"hello": "Hello! DIO!",
@@ -85,6 +88,9 @@ In localization codes of application:
8588
```
8689

8790
```js
91+
import Vue from 'vue'
92+
import VueI18n from 'vue-i18n'
93+
8894
// import some components used in i18n component
8995
import Banner from './path/to/components/Banner.vue'
9096
import Modal from './path/to/components/Modal.vue'

docs/rules/no-missing-keys.md

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,8 @@ localization codes:
4242
```
4343

4444
```js
45+
import VueI18n from 'vue-i18n'
46+
4547
const i18n = new VueI18n({
4648
locale: 'en',
4749
messages: {
@@ -67,17 +69,19 @@ localization codes:
6769
```vue
6870
<template>
6971
<div class="app">
70-
<!-- GOOD -->
72+
<!-- GOOD -->
7173
<p>{{ $t('hello') }}</p>
72-
<!-- GOOD -->
74+
<!-- GOOD -->
7375
<p v-t="'hello'"></p>
74-
<!-- GOOD -->
76+
<!-- GOOD -->
7577
<i18n path="hello" tag="p"></i18n>
7678
</div>
7779
</template>
7880
```
7981

8082
```js
83+
import VueI18n from 'vue-i18n'
84+
8185
const i18n = new VueI18n({
8286
locale: 'en',
8387
messages: {

docs/rules/no-unused-keys.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ This rule is aimed at eliminating unused localization keys.
1111
:-1: Examples of **incorrect** code for this rule:
1212

1313
locale messages:
14-
```js
14+
```json
1515
// ✗ BAD
1616
{
1717
"hello": "Hello! DIO!",
@@ -30,6 +30,8 @@ In localization codes of application:
3030
```
3131

3232
```js
33+
import VueI18n from 'vue-i18n'
34+
3335
const i18n = new VueI18n({
3436
locale: 'en',
3537
messages: {
@@ -43,7 +45,7 @@ i18n.t('hello')
4345
:+1: Examples of **correct** code for this rule:
4446

4547
locale messages:
46-
```js
48+
```json
4749
// ✓ GOOD
4850
{
4951
"hello": "Hello! DIO!",
@@ -62,6 +64,8 @@ In localization codes of application:
6264
```
6365

6466
```js
67+
import VueI18n from 'vue-i18n'
68+
6569
const i18n = new VueI18n({
6670
locale: 'en',
6771
messages: {

docs/started.md

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -20,21 +20,21 @@ Configure your `.eslintrc.*` file.
2020
For example:
2121

2222
```js
23-
{
24-
"extends": [
25-
"eslint:recommended",
26-
"plugin:vue-i18n/recommended"
23+
module.export = {
24+
extends: [
25+
'eslint:recommended',
26+
'plugin:vue-i18n/recommended'
2727
],
28-
"rules": {
28+
rules: {
2929
// Optional.
30-
"vue-i18n/no-dynamic-keys": "error",
31-
"vue-i18n/no-unused-keys": ["error", {
32-
"extensions": [".js", ".vue"]
30+
'vue-i18n/no-dynamic-keys': 'error',
31+
'vue-i18n/no-unused-keys': ['error', {
32+
extensions: ['.js', '.vue']
3333
}]
3434
},
35-
"settings": {
36-
"vue-i18n": {
37-
"localeDir": "./path/to/locales/*.json" // extention is glob formatting!
35+
settings: {
36+
'vue-i18n': {
37+
localeDir: './path/to/locales/*.json' // extention is glob formatting!
3838
}
3939
}
4040
}

package.json

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -23,6 +23,7 @@
2323
"conventional-changelog-cli": "^2.0.12",
2424
"conventional-github-releaser": "^3.1.2",
2525
"eslint": "^5.15.0",
26+
"eslint-plugin-markdown": "^1.0.0",
2627
"eslint-plugin-vue-libs": "^3.0.0",
2728
"git-commit-message-convention": "git://github.com/kazupon/git-commit-message-convention.git",
2829
"mocha": "^6.0.2",
@@ -66,6 +67,7 @@
6667
"docs:build": "vuepress build docs",
6768
"generate": "node scripts/update.js",
6869
"lint": "eslint lib scripts tests docs/.vuepress --ignore-pattern \"!.*\"",
70+
"lint:docs": "eslint --ext js,vue,md docs --ignore-pattern \"!.*\"",
6971
"release": "conventional-github-releaser -n ./node_modules/git-commit-message-convention/convention.js",
7072
"test": "mocha ./tests/**/*.js",
7173
"test:coverage": "nyc mocha ./tests/**/*.js"

0 commit comments

Comments
 (0)