Skip to content

Commit 980c7cb

Browse files
committed
👕 refactor(eslint): fix eslint errors
1 parent 3801400 commit 980c7cb

File tree

2 files changed

+20
-29
lines changed

2 files changed

+20
-29
lines changed

src/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ export function directive (vnode, dir) {
3131
return
3232
}
3333

34-
let params = []
34+
const params = []
3535
locale && params.push(locale)
3636

3737
if (args && (Array.isArray(args) || isPlainObject(args))) {

test/directive.test.js

Lines changed: 19 additions & 28 deletions
Original file line numberDiff line numberDiff line change
@@ -23,11 +23,12 @@ const options = {
2323
}
2424
}
2525

26+
const i18n = new VueI18n(options)
27+
const renderer = createRenderer({
28+
directives: { t: directive }
29+
})
30+
2631
test('string literal', t => {
27-
const i18n = new VueI18n(options)
28-
const renderer = createRenderer({
29-
directives: { t: directive }
30-
})
3132
const app = new Vue({
3233
i18n,
3334
render (h) {
@@ -40,16 +41,14 @@ test('string literal', t => {
4041
})
4142
}
4243
})
44+
4345
renderer.renderToString(app, (err, html) => {
46+
t.falsy(err)
4447
t.is(html, '<p data-server-rendered=\"true\">hello</p>')
4548
})
4649
})
4750

4851
test('object', t => {
49-
const i18n = new VueI18n(options)
50-
const renderer = createRenderer({
51-
directives: { t: directive }
52-
})
5352
const app = new Vue({
5453
i18n,
5554
data: { msgPath: 'named' },
@@ -64,16 +63,14 @@ test('object', t => {
6463
})
6564
}
6665
})
66+
6767
renderer.renderToString(app, (err, html) => {
68+
t.falsy(err)
6869
t.is(html, '<p data-server-rendered=\"true\">やあ、kazupon!</p>')
6970
})
7071
})
7172

7273
test('has some children', t => {
73-
const i18n = new VueI18n(options)
74-
const renderer = createRenderer({
75-
directives: { t: directive }
76-
})
7774
const app = new Vue({
7875
i18n,
7976
render (h) {
@@ -91,18 +88,16 @@ test('has some children', t => {
9188
}, [h('p', ['child1']), h('p', ['child2'])])
9289
}
9390
})
91+
9492
renderer.renderToString(app, (err, html) => {
93+
t.falsy(err)
9594
t.is(html, '<div data-server-rendered=\"true\">hello</div>')
9695
})
9796
})
9897

9998
test('not support value type warning', t => {
10099
const spy = sinon.spy(console, 'warn')
101100

102-
const i18n = new VueI18n(options)
103-
const renderer = createRenderer({
104-
directives: { t: directive }
105-
})
106101
const app = new Vue({
107102
i18n,
108103
render (h) {
@@ -114,7 +109,9 @@ test('not support value type warning', t => {
114109
})
115110
}
116111
})
112+
117113
renderer.renderToString(app, (err, html) => {
114+
t.falsy(err)
118115
t.is(html, '<p data-server-rendered=\"true\"></p>')
119116
t.true(spy.withArgs('[vue-i18n-extensions] not support value type').calledOnce)
120117
spy.restore()
@@ -124,10 +121,6 @@ test('not support value type warning', t => {
124121
test('required path warning', t => {
125122
const spy = sinon.spy(console, 'warn')
126123

127-
const i18n = new VueI18n(options)
128-
const renderer = createRenderer({
129-
directives: { t: directive }
130-
})
131124
const app = new Vue({
132125
i18n,
133126
data: { msgPath: 'named' },
@@ -142,7 +135,9 @@ test('required path warning', t => {
142135
})
143136
}
144137
})
138+
145139
renderer.renderToString(app, (err, html) => {
140+
t.falsy(err)
146141
t.is(html, '<p data-server-rendered=\"true\"></p>')
147142
t.true(spy.withArgs('[vue-i18n-extensions] required `path` in v-t directive').calledOnce)
148143
spy.restore()
@@ -152,10 +147,6 @@ test('required path warning', t => {
152147
test('not exist VueI18n instance warning', t => {
153148
const spy = sinon.spy(console, 'warn')
154149

155-
const i18n = new VueI18n(options)
156-
const renderer = createRenderer({
157-
directives: { t: directive }
158-
})
159150
const app = new Vue({
160151
render (h) {
161152
// <p v-t="'hello'"></p>
@@ -167,18 +158,16 @@ test('not exist VueI18n instance warning', t => {
167158
})
168159
}
169160
})
161+
170162
renderer.renderToString(app, (err, html) => {
163+
t.falsy(err)
171164
t.is(html, '<p data-server-rendered=\"true\"></p>')
172165
t.true(spy.withArgs('[vue-i18n-extensions] not exist VueI18n instance in Vue instance').calledOnce)
173166
spy.restore()
174167
})
175168
})
176169

177170
test('array args', t => {
178-
const i18n = new VueI18n(options)
179-
const renderer = createRenderer({
180-
directives: { t: directive }
181-
})
182171
const app = new Vue({
183172
i18n,
184173
data: { msgPath: 'list' },
@@ -193,7 +182,9 @@ test('array args', t => {
193182
})
194183
}
195184
})
185+
196186
renderer.renderToString(app, (err, html) => {
187+
t.falsy(err)
197188
t.is(html, '<p data-server-rendered=\"true\">やあ、kazupon!</p>')
198189
})
199190
})

0 commit comments

Comments
 (0)