chore: eslint upgrade and lint fixes

kazupon · kazupon · commit 0fde190ca417 · 2024-04-21T00:40:40.000+09:00
diff --git a/benchmark/utils.mjs b/benchmark/utils.mjs
@@ -1,6 +1,5 @@
 import fs from 'fs/promises'
 
-// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
 export async function readJson(path) {
   const data = await fs.readFile(path, 'utf8')
   return JSON.parse(data)
diff --git a/e2e/helper.ts b/e2e/helper.ts
@@ -51,7 +51,6 @@ export function getDom(html: string) {
 }
 
 export function getDataFromDom(dom: Document, selector: string) {
-  // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
   return JSON.parse(
     dom.querySelector(selector)!.textContent!.replace('&quot;', '"')
   )
@@ -66,7 +65,7 @@ export function assertLocaleHeadWithDom(dom: Document, headSelector: string) {
       if (key === 'id') {
         continue
       }
-      // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+
       const v = tag!.getAttribute(key)
       if (v !== value) {
         throw new Error(`${key} ${v} !== ${value}`)
diff --git a/package.json b/package.json
@@ -95,9 +95,9 @@
     "bumpp": "^9.3.0",
     "cross-env": "^7.0.3",
     "esbuild-register": "^3.5.0",
-    "eslint": "^8.57.0",
+    "eslint": "^9.1.0",
     "eslint-config-prettier": "^9.1.0",
-    "eslint-plugin-vue": "^9.24.0",
+    "eslint-plugin-vue": "^9.25.0",
     "execa": "^5.0.0",
     "fixpack": "^4.0.0",
     "globals": "^15.0.0",
@@ -173,7 +173,7 @@
       "secretlint"
     ]
   },
-  "packageManager": "pnpm@8.9.2",
+  "packageManager": "pnpm@9.0.4",
   "pnpm": {
     "overrides": {
       "vue": "3.4.20",
diff --git a/packages/core-base/src/context.ts b/packages/core-base/src/context.ts
@@ -116,7 +116,7 @@ export type LocaleMessages<
  *
  * @VueI18nGeneral
  */
-export interface DefineCoreLocaleMessage extends LocaleMessage<string> {} // eslint-disable-line @typescript-eslint/no-empty-interface
+export interface DefineCoreLocaleMessage extends LocaleMessage<string> {}
 
 export type DefaultCoreLocaleMessageSchema<
   Schema = RemoveIndexSignature<{
@@ -252,7 +252,7 @@ export interface CoreOptions<
 export interface CoreInternalOptions {
   __datetimeFormatters?: Map<string, Intl.DateTimeFormat>
   __numberFormatters?: Map<string, Intl.NumberFormat>
-  __v_emitter?: VueDevToolsEmitter // eslint-disable-line camelcase
+  __v_emitter?: VueDevToolsEmitter
   __meta?: MetaInfo
 }
 
@@ -327,7 +327,7 @@ export interface CoreInternalContext {
   __datetimeFormatters: Map<string, Intl.DateTimeFormat>
   __numberFormatters: Map<string, Intl.NumberFormat>
   __localeChainCache?: Map<Locale, Locale[]>
-  __v_emitter?: VueDevToolsEmitter // eslint-disable-line camelcase
+  __v_emitter?: VueDevToolsEmitter
   __meta: MetaInfo // for Intlify DevTools
 }
 
diff --git a/packages/core-base/src/fallbacker.ts b/packages/core-base/src/fallbacker.ts
@@ -87,7 +87,7 @@ export type LocaleFallbacker = <Message = string>(
 export function fallbackWithSimple<Message = string>(
   ctx: CoreContext<Message>,
   fallback: FallbackLocale,
-  start: Locale // eslint-disable-line @typescript-eslint/no-unused-vars
+  start: Locale
 ): Locale[] {
   // prettier-ignore
   return [...new Set(
diff --git a/packages/format-explorer/src/shims-vue.d.ts b/packages/format-explorer/src/shims-vue.d.ts
@@ -1,6 +1,6 @@
 declare module '*.vue' {
   import { DefineComponent } from 'vue'
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/ban-types
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   const component: DefineComponent<{}, {}, any>
   // @ts-ignore
   export default component
diff --git a/packages/message-compiler/src/generator.ts b/packages/message-compiler/src/generator.ts
@@ -284,7 +284,7 @@ function generateNode(generator: CodeGenerator, node: Node): void {
 // generate code from AST
 export const generate = (
   ast: ResourceNode,
-  options: CodeGenOptions = {} // eslint-disable-line
+  options: CodeGenOptions = {}
 ): CodeGenResult => {
   const mode = isString(options.mode) ? options.mode : 'normal'
   const filename = isString(options.filename)
diff --git a/packages/message-compiler/src/scanner.ts b/packages/message-compiler/src/scanner.ts
@@ -79,7 +79,7 @@ export function createScanner(str: string): Scanner {
 
   function skipToPeek(): void {
     const target = _index + _peekOffset
-    // eslint-disable-next-line no-unmodified-loop-condition
+
     while (target !== _index) {
       next()
     }
diff --git a/packages/message-compiler/src/tokenizer.ts b/packages/message-compiler/src/tokenizer.ts
@@ -481,7 +481,7 @@ export function createTokenizer(
 
   function readText(scnr: Scanner): string {
     let buf = ''
-    // eslint-disable-next-line no-constant-condition
+
     while (true) {
       const ch = scnr.currentChar()
       if (
diff --git a/packages/shared/src/messages.ts b/packages/shared/src/messages.ts
@@ -1,7 +1,7 @@
 import { isArray, isObject } from './utils'
 
 const isNotObjectOrIsArray = (val: unknown) => !isObject(val) || isArray(val)
-// eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/explicit-module-boundary-types
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 export function deepCopy(src: any, des: any): void {
   // src and des should both be objects, and none of them can be a array
   if (isNotObjectOrIsArray(src) || isNotObjectOrIsArray(des)) {
diff --git a/packages/size-check-petite-vue-i18n/src/shims-vue.d.ts b/packages/size-check-petite-vue-i18n/src/shims-vue.d.ts
@@ -1,6 +1,6 @@
 declare module '*.vue' {
   import { DefineComponent } from 'vue'
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/ban-types
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   const component: DefineComponent<{}, {}, any>
   // @ts-ignore
   export default component
diff --git a/packages/size-check-vue-i18n/src/shims-vue.d.ts b/packages/size-check-vue-i18n/src/shims-vue.d.ts
@@ -1,6 +1,6 @@
 declare module '*.vue' {
   import { DefineComponent } from 'vue'
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/ban-types
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   const component: DefineComponent<{}, {}, any>
   // @ts-ignore
   export default component
diff --git a/packages/vue-i18n-core/src/components/DatetimeFormat.ts b/packages/vue-i18n-core/src/components/DatetimeFormat.ts
@@ -6,7 +6,6 @@ import { DatetimePartsSymbol } from '../symbols'
 import { renderFormatter } from './formatRenderer'
 import { baseFormatProps } from './base'
 
-/* eslint-enable @typescript-eslint/no-unused-vars */
 import type { VNodeProps } from 'vue'
 import type { DateTimeOptions } from '@intlify/core-base'
 import type { Composer, ComposerInternal } from '../composer'
diff --git a/packages/vue-i18n-core/src/components/Translation.ts b/packages/vue-i18n-core/src/components/Translation.ts
@@ -39,7 +39,7 @@ export const TranslationImpl = /*#__PURE__*/ defineComponent({
       },
       plural: {
         type: [Number, String],
-        // eslint-disable-next-line @typescript-eslint/no-explicit-any
+
         validator: (val: any): boolean => isNumber(val) || !isNaN(val)
       }
     },
diff --git a/packages/vue-i18n-core/src/composer.ts b/packages/vue-i18n-core/src/composer.ts
@@ -150,7 +150,7 @@ export type VueMessageType = string | ResourceNode | VNode
  *
  * @VueI18nGeneral
  */
-export interface DefineLocaleMessage extends LocaleMessage<VueMessageType> {} // eslint-disable-line @typescript-eslint/no-empty-interface
+export interface DefineLocaleMessage extends LocaleMessage<VueMessageType> {}
 
 /**
  * The type definition of datetime format
@@ -177,7 +177,7 @@ export interface DefineLocaleMessage extends LocaleMessage<VueMessageType> {} //
  *
  * @VueI18nGeneral
  */
-export interface DefineDateTimeFormat extends DateTimeFormat {} // eslint-disable-line @typescript-eslint/no-empty-interface
+export interface DefineDateTimeFormat extends DateTimeFormat {}
 
 /**
  * The type definition of number format
@@ -205,7 +205,7 @@ export interface DefineDateTimeFormat extends DateTimeFormat {} // eslint-disabl
  *
  * @VueI18nGeneral
  */
-export interface DefineNumberFormat extends NumberFormat {} // eslint-disable-line @typescript-eslint/no-empty-interface
+export interface DefineNumberFormat extends NumberFormat {}
 
 export type DefaultLocaleMessageSchema<
   Schema = RemoveIndexSignature<{
@@ -1196,7 +1196,7 @@ export interface ComposerNumberFormatting<
  *
  * @VueI18nComposition
  */
-export interface ComposerCustom {} // eslint-disable-line @typescript-eslint/no-empty-interface
+export interface ComposerCustom {}
 
 /**
  * Composer interfaces
@@ -1801,9 +1801,9 @@ function defineCoreMissingHandler(missing: MissingHandler): CoreMissingHandler {
 /* #__NO_SIDE_EFFECTS__ */
 const getMetaInfo = (): MetaInfo | null => {
   const instance = getCurrentInstance()
-  let meta: any = null // eslint-disable-line @typescript-eslint/no-explicit-any
+  let meta: any = null
   return instance && (meta = getComponentOptions(instance)[DEVTOOLS_META])
-    ? { [DEVTOOLS_META]: meta } // eslint-disable-line @typescript-eslint/no-explicit-any
+    ? { [DEVTOOLS_META]: meta }
     : null
 }
 
@@ -1867,7 +1867,7 @@ export function createComposer<
  *
  * @internal
  */
-// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
+
 export function createComposer(options: any = {}, VueI18nLegacy?: any): any {
   type Message = VueMessageType
   const { __root, __injectWithOption } = options as ComposerInternalOptions<
@@ -2172,7 +2172,7 @@ export function createComposer(options: any = {}, VueI18nLegacy?: any): any {
 
   function isResolvedTranslateMessage(
     type: ComposerWarnType,
-    arg: any // eslint-disable-line @typescript-eslint/no-explicit-any
+    arg: any
   ): boolean {
     return type !== 'translate' || !arg.resolvedMessage
   }
@@ -2337,7 +2337,7 @@ export function createComposer(options: any = {}, VueI18nLegacy?: any): any {
       },
       () => parseTranslateArgs(...args),
       'translate',
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+
       root => (root as any)[TranslateVNodeSymbol](...args),
       key => [createTextNode(key as string)],
       val => isArray(val)
@@ -2350,7 +2350,7 @@ export function createComposer(options: any = {}, VueI18nLegacy?: any): any {
       context => Reflect.apply(number, null, [context, ...args]),
       () => parseNumberArgs(...args),
       'number format',
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+
       root => (root as any)[NumberPartsSymbol](...args),
       NOOP_RETURN_ARRAY,
       val => isString(val) || isArray(val)
@@ -2365,7 +2365,7 @@ export function createComposer(options: any = {}, VueI18nLegacy?: any): any {
       context => Reflect.apply(datetime, null, [context, ...args]),
       () => parseDateTimeArgs(...args),
       'datetime format',
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+
       root => (root as any)[DatetimePartsSymbol](...args),
       NOOP_RETURN_ARRAY,
       val => isString(val) || isArray(val)
diff --git a/packages/vue-i18n-core/src/i18n.ts b/packages/vue-i18n-core/src/i18n.ts
@@ -518,7 +518,7 @@ export function createI18n<
     ? I18n<Messages, DateTimeFormats, NumberFormats, OptionLocale, false>
     : I18n<Messages, DateTimeFormats, NumberFormats, OptionLocale, Legacy>
 
-// eslint-disable-next-line @typescript-eslint/no-explicit-any, @typescript-eslint/explicit-module-boundary-types
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 export function createI18n(options: any = {}, VueI18nLegacy?: any): any {
   type _I18n = I18n & I18nInternal
 
@@ -828,7 +828,7 @@ export function useI18n<
   NonNullable<Options['numberFormats']>,
   Options['locale'] extends unknown ? string : Options['locale']
 >
-// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
+
 export function useI18n<
   Options extends UseI18nOptions = UseI18nOptions,
   Messages extends Record<string, unknown> = NonNullable<Options['messages']>,
diff --git a/packages/vue-i18n-core/src/legacy.ts b/packages/vue-i18n-core/src/legacy.ts
@@ -77,7 +77,6 @@ export type DateTimeFormatResult = string
 /** @VueI18nLegacy */
 export type NumberFormatResult = string
 export interface Formatter {
-  // eslint-disable-next-line @typescript-eslint/no-explicit-any
   interpolate(message: string, values: any, path: string): Array<any> | null
 }
 export type VueI18nExtender = (vueI18n: VueI18n) => Disposer | undefined
@@ -1465,7 +1464,7 @@ export function createVueI18n<
  *
  * @internal
  */
-// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
+
 export function createVueI18n(options: any = {}, VueI18nLegacy?: any): any {
   type Message = VueMessageType
 
diff --git a/packages/vue-i18n-core/src/mixins/bridge.ts b/packages/vue-i18n-core/src/mixins/bridge.ts
@@ -10,7 +10,7 @@ import type { I18n } from '../i18n'
  */
 export function defineMixin(
   i18n: I18n,
-  VueI18n: any // eslint-disable-line @typescript-eslint/no-explicit-any, @typescript-eslint/explicit-module-boundary-types
+  VueI18n: any // eslint-disable-line @typescript-eslint/no-explicit-any
 ): ComponentOptions {
   return {
     beforeCreate(): void {
diff --git a/packages/vue-i18n-core/src/utils.ts b/packages/vue-i18n-core/src/utils.ts
@@ -38,7 +38,6 @@ declare module 'vue' {
   }
 }
 
-// eslint-disable-next-line @typescript-eslint/explicit-module-boundary-types
 export function isLegacyVueI18n(VueI18n: any): boolean {
   if (VueI18n == null || VueI18n.version == null) {
     return false
@@ -148,15 +147,14 @@ export function getLocaleMessages<Messages = {}>(
   return ret as { [K in keyof Messages]: Messages[K] }
 }
 
-// eslint-disable-next-line @typescript-eslint/no-explicit-any
 export function getComponentOptions(instance: ComponentInternalInstance): any {
   return !__BRIDGE__ ? instance.type : instance.proxy!.$options
 }
 
 export function adjustI18nResources(
   gl: Composer,
   options: ComposerOptions,
-  componentOptions: any // eslint-disable-line @typescript-eslint/no-explicit-any
+  componentOptions: any
 ): void {
   let messages = isObject(options.messages) ? options.messages : {}
   if ('__i18nGlobal' in componentOptions) {
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/test-dts/core-base/context.test-d.ts b/test-dts/core-base/context.test-d.ts
diff --git a/test-dts/core-base/datetime.test-d.ts b/test-dts/core-base/datetime.test-d.ts
diff --git a/test-dts/core-base/number.test-d.ts b/test-dts/core-base/number.test-d.ts
diff --git a/test-dts/core-base/translate.test-d.ts b/test-dts/core-base/translate.test-d.ts
diff --git a/test-dts/vue-i18n/i18n.test-d.ts b/test-dts/vue-i18n/i18n.test-d.ts
diff --git a/test-dts/vue-i18n/legacy.test-d.ts b/test-dts/vue-i18n/legacy.test-d.ts

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,6 @@ export function getDom(html: string) {`
`51`	`51`	`}`
`52`	`52`
`53`	`53`	`export function getDataFromDom(dom: Document, selector: string) {`
`54`		`- // eslint-disable-next-line @typescript-eslint/no-non-null-assertion`
`55`	`54`	`return JSON.parse(`
`56`	`55`	`dom.querySelector(selector)!.textContent!.replace('"', '"')`
`57`	`56`	`)`
`@@ -66,7 +65,7 @@ export function assertLocaleHeadWithDom(dom: Document, headSelector: string) {`
`66`	`65`	`if (key === 'id') {`
`67`	`66`	`continue`
`68`	`67`	`}`
`69`		`- // eslint-disable-next-line @typescript-eslint/no-non-null-assertion`
	`68`	`+`
`70`	`69`	`const v = tag!.getAttribute(key)`
`71`	`70`	`if (v !== value) {`
`72`	`71`	throw new Error(`${key} ${v} !== ${value}`)
Original file line number	Diff line number	Diff line change
`@@ -79,7 +79,7 @@ export function createScanner(str: string): Scanner {`
`79`	`79`
`80`	`80`	`function skipToPeek(): void {`
`81`	`81`	`const target = _index + _peekOffset`
`82`		`- // eslint-disable-next-line no-unmodified-loop-condition`
	`82`	`+`
`83`	`83`	`while (target !== _index) {`
`84`	`84`	`next()`
`85`	`85`	`}`