improvement: deprecated __VUE_I18N_PROD_DEVTOOLS__ feature flag (#583)

kazupon · web-flow · commit 2cb2e2cabc07 · 2021-07-18T05:13:38.000+09:00
* breaking: deprecated __VUE_I18N_PROD_DEVTOOLS__ feature flag

* updates
diff --git a/docs/guide/advanced/optimization.md b/docs/guide/advanced/optimization.md
@@ -93,7 +93,6 @@ The `esm-bundler` builds now exposes global feature flags that can be overwritte
 
 - `__VUE_I18N_FULL_INSTALL__` (enable/disable, in addition to vue-i18n APIs, components and directives all fully support installation: `true`)
 - `__VUE_I18N_LEGACY_API__` (enable/disable vue-i18n legacy style APIs support, default: `true`)
-- `__VUE_I18N_PROD_DEVTOOLS__` (enable/disable vue-devtools support in production, default: `false`)
 - `__INTLIFY_PROD_DEVTOOLS__` (enable/disable `@intlify/devtools` support in production, default: `false`)
 
 :::warning NOTICE
diff --git a/packages/size-check-vue-i18n/rollup.config.js b/packages/size-check-vue-i18n/rollup.config.js
@@ -28,7 +28,6 @@ const config = {
       __VUE_PROD_DEVTOOLS__: false,
       __VUE_I18N_LEGACY_API__: false,
       __VUE_I18N_FULL_INSTALL__: false,
-      __VUE_I18N_PROD_DEVTOOLS__: false,
       __INTLIFY_PROD_DEVTOOLS__: false,
       'process.env.NODE_ENV': JSON.stringify('production')
     }),
diff --git a/packages/vue-i18n/README.md b/packages/vue-i18n/README.md
@@ -52,7 +52,6 @@ The `esm-bundler` builds now exposes global feature flags that can be overwritte
 
 - `__VUE_I18N_FULL_INSTALL__` (enable/disable, in addition to vue-i18n APIs, components and directives all fully support installation: `true`)
 - `__VUE_I18N_LEGACY_API__` (enable/disable vue-i18n legacy style APIs support, default: `true`)
-- `__VUE_I18N_PROD_DEVTOOLS__` (enable/disable vue-devtools support in production, default: `false`)
 - `__INTLIFY_PROD_DEVTOOLS__` (enable/disable `@intlify/devtools` support in production, default: `false`)
 
 > NOTE: `__INTLIFY_PROD_DEVTOOLS__` flag is experimental, and `@intlify/devtools` is WIP yet.
diff --git a/packages/vue-i18n/src/misc.ts b/packages/vue-i18n/src/misc.ts
@@ -27,11 +27,6 @@ export function initFeatureFlags(): void {
     getGlobalThis().__VUE_I18N_LEGACY_API__ = true
   }
 
-  if (typeof __FEATURE_PROD_VUE_DEVTOOLS__ !== 'boolean') {
-    needWarn = true
-    getGlobalThis().__VUE_I18N_PROD_DEVTOOLS__ = false
-  }
-
   if (typeof __FEATURE_PROD_INTLIFY_DEVTOOLS__ !== 'boolean') {
     getGlobalThis().__INTLIFY_PROD_DEVTOOLS__ = false
   }
diff --git a/rollup.config.js b/rollup.config.js
@@ -230,7 +230,7 @@ function createReplacePlugin(
       ? `__VUE_I18N_LEGACY_API__`
       : true,
     __FEATURE_PROD_VUE_DEVTOOLS__: isBundlerESMBuild
-      ? `__VUE_I18N_PROD_DEVTOOLS__`
+      ? `__VUE_PROD_DEVTOOLS__`
       : false,
     __FEATURE_PROD_INTLIFY_DEVTOOLS__: isBundlerESMBuild
       ? `__INTLIFY_PROD_DEVTOOLS__`

Original file line number	Diff line number	Diff line change
`@@ -27,11 +27,6 @@ export function initFeatureFlags(): void {`
`27`	`27`	`getGlobalThis().__VUE_I18N_LEGACY_API__ = true`
`28`	`28`	`}`
`29`	`29`
`30`		`- if (typeof __FEATURE_PROD_VUE_DEVTOOLS__ !== 'boolean') {`
`31`		`- needWarn = true`
`32`		`- getGlobalThis().__VUE_I18N_PROD_DEVTOOLS__ = false`
`33`		`- }`
`34`		`-`
`35`	`30`	`if (typeof __FEATURE_PROD_INTLIFY_DEVTOOLS__ !== 'boolean') {`
`36`	`31`	`getGlobalThis().__INTLIFY_PROD_DEVTOOLS__ = false`
`37`	`32`	`}`