breaking: drop modulo interpolation syntax (#1814)

Author: kazupon

e2e/formatting/ruby.spec.ts

@@ -1,7 +1,6 @@
 import { warn, format, isObject, isBoolean, isString } from '@intlify/shared'
 import {
   baseCompile as baseCompileCore,
-  CompileWarnCodes,
   defaultOnError,
   detectHtmlTag
 } from '@intlify/message-compiler'
@@ -12,8 +11,7 @@ import type {
   CompileOptions,
   CompileError,
   CompilerResult,
-  ResourceNode,
-  CompileWarn
+  ResourceNode
 } from '@intlify/message-compiler'
 import type { MessageFunction, MessageFunctions } from './runtime'
 import type { MessageCompilerContext } from './context'
@@ -29,17 +27,6 @@ function checkHtmlMessage(source: string, warnHtmlMessage?: boolean): void {
 const defaultOnCacheKey = (message: string): string => message
 let compileCache: unknown = Object.create(null)
 
-function onCompileWarn(_warn: CompileWarn): void {
-  if (_warn.code === CompileWarnCodes.USE_MODULO_SYNTAX) {
-    warn(
-      `The use of named interpolation with modulo syntax is deprecated. ` +
-        `It will be removed in v10.\n` +
-        `reference: https://vue-i18n.intlify.dev/guide/essentials/syntax#rails-i18n-format \n` +
-        `(message compiler warning message: ${_warn.message})`
-    )
-  }
-}
-
 export function clearCompileCache(): void {
   compileCache = Object.create(null)
 }
@@ -77,11 +64,6 @@ export const compileToFunction = <
     throw createCoreError(CoreErrorCodes.NOT_SUPPORT_NON_STRING_MESSAGE)
   }
 
-  // set onWarn
-  if (__DEV__) {
-    context.onWarn = onCompileWarn
-  }
-
   if (__RUNTIME__) {
     __DEV__ &&
       warn(
@@ -125,11 +107,6 @@ export function compile<
   message: MessageSource,
   context: MessageCompilerContext
 ): MessageFunction<Message> {
-  // set onWarn
-  if (__DEV__) {
-    context.onWarn = onCompileWarn
-  }
-
   if (
     (__ESM_BROWSER__ ||
       __NODE_JS__ ||

examples/composition/formatting/ruby.html

@@ -145,7 +145,7 @@ export type PostTranslationHandler<Message = string> = (
  */
 export type MessageCompilerContext = Pick<
   CompileOptions,
-  'onError' | 'onCacheKey' | 'onWarn'
+  'onError' | 'onCacheKey'
 > & {
   /**
    * Whether to allow the use locale messages of HTML formatting.

examples/legacy/formatting/ruby.html

@@ -1,18 +1,17 @@
 import { format, incrementer } from '@intlify/shared'
-import { CompileWarnCodes } from '@intlify/message-compiler'
 
-const code = CompileWarnCodes.__EXTEND_POINT__
+const code = 1
 const inc = incrementer(code)
 
 export const CoreWarnCodes = {
-  NOT_FOUND_KEY: code, // 2
-  FALLBACK_TO_TRANSLATE: inc(), // 3
-  CANNOT_FORMAT_NUMBER: inc(), // 4
-  FALLBACK_TO_NUMBER_FORMAT: inc(), // 5
-  CANNOT_FORMAT_DATE: inc(), // 6
-  FALLBACK_TO_DATE_FORMAT: inc(), // 7
-  EXPERIMENTAL_CUSTOM_MESSAGE_COMPILER: inc(), // 8
-  __EXTEND_POINT__: inc() // 9
+  NOT_FOUND_KEY: code, // 1
+  FALLBACK_TO_TRANSLATE: inc(), // 2
+  CANNOT_FORMAT_NUMBER: inc(), // 3
+  FALLBACK_TO_NUMBER_FORMAT: inc(), // 4
+  CANNOT_FORMAT_DATE: inc(), // 5
+  FALLBACK_TO_DATE_FORMAT: inc(), // 6
+  EXPERIMENTAL_CUSTOM_MESSAGE_COMPILER: inc(), // 7
+  __EXTEND_POINT__: inc() // 8
 } as const
 
 export type CoreWarnCodes = (typeof CoreWarnCodes)[keyof typeof CoreWarnCodes]

examples/petite/formatting/ruby.html

@@ -60,19 +60,6 @@ describe('compileToFunction', () => {
     })
     expect(occured).toBe(true)
   })
-
-  test('modulo syntax warning', () => {
-    const mockWarn = vi.spyOn(shared, 'warn')
-    mockWarn.mockImplementation(() => {})
-
-    compileToFunction('hello %{name}!', {
-      ...DEFAULT_CONTEXT
-    })
-    expect(mockWarn).toHaveBeenCalledTimes(1)
-    expect(mockWarn.mock.calls[0][0]).includes(
-      `The use of named interpolation with modulo syntax is deprecated. It will be removed in v10.`
-    )
-  })
 })
 
 describe('compile', () => {
@@ -132,15 +119,4 @@ describe('compile', () => {
     })
     expect(occured).toBe(true)
   })
-
-  test('modulo syntax warning', () => {
-    const mockWarn = vi.spyOn(shared, 'warn')
-    mockWarn.mockImplementation(() => {})
-
-    compile('%{msg} world!', DEFAULT_CONTEXT)
-    expect(mockWarn).toHaveBeenCalledTimes(1)
-    expect(mockWarn.mock.calls[0][0]).includes(
-      `The use of named interpolation with modulo syntax is deprecated. It will be removed in v10.`
-    )
-  })
 })

packages/core-base/src/compilation.ts

@@ -1,5 +1,5 @@
 import { CoreWarnCodes } from '../src/warnings'
 
 test('CoreWarnCodes', () => {
-  expect(CoreWarnCodes.NOT_FOUND_KEY).toBe(2)
+  expect(CoreWarnCodes.NOT_FOUND_KEY).toBe(1)
 })

packages/core-base/src/context.ts

@@ -1,7 +1,6 @@
 export * from './location'
 export * from './nodes'
 export * from './options'
-export * from './warnings'
 export * from './errors'
 export * from './helpers'
 export * from './parser'