perf: reduce AST size (#1456)

Author: kazupon

packages/message-compiler/src/compiler.ts

@@ -26,9 +26,6 @@ export function baseCompile(
     // transform ASTs
     transform(ast, assignedOptions)
 
-    // optimize ASTs
-    doOptimize && optimize(ast)
-
     // generate javascript codes
     return generate(ast, assignedOptions)
   } else {

packages/message-compiler/src/nodes.ts

@@ -50,7 +50,7 @@ type MessageElementNode =
 
 export interface TextNode extends Node {
   type: NodeTypes.Text
-  value: string
+  value?: string
 }
 
 export interface NamedNode extends Node {
@@ -65,7 +65,7 @@ export interface ListNode extends Node {
 
 export interface LiteralNode extends Node {
   type: NodeTypes.Literal
-  value: string
+  value?: string
 }
 
 export interface LinkedNode extends Node {

packages/message-compiler/src/optimizer.ts

@@ -18,6 +18,7 @@ function optimizeMessageNode(message: MessageNode) {
     const item = message.items[0]
     if (item.type === NodeTypes.Text || item.type === NodeTypes.Literal) {
       message.static = item.value
+      delete item.value // optimization for size
     }
   } else {
     const values: string[] = []
@@ -26,10 +27,19 @@ function optimizeMessageNode(message: MessageNode) {
       if (!(item.type === NodeTypes.Text || item.type === NodeTypes.Literal)) {
         break
       }
+      if (item.value == null) {
+        break
+      }
       values.push(item.value)
     }
     if (values.length === message.items.length) {
       message.static = join(values)
+      for (let i = 0; i < message.items.length; i++) {
+        const item = message.items[i]
+        if (item.type === NodeTypes.Text || item.type === NodeTypes.Literal) {
+          delete item.value // optimization for size
+        }
+      }
     }
   }
 }

packages/message-compiler/test/__snapshots__/compiler.test.ts.snap

@@ -263,7 +263,6 @@ exports[`compiler options > jit: true > ast 1`] = `
     "items": [
       {
         "type": 3,
-        "value": "hello world",
       },
     ],
     "static": "hello world",
@@ -282,7 +281,6 @@ exports[`compiler options > location: false > ast 1`] = `
         "value": "hello world",
       },
     ],
-    "static": "hello world",
     "type": 2,
   },
   "type": 0,

packages/message-compiler/test/__snapshots__/optimizer.test.ts.snap

@@ -6,15 +6,12 @@ exports[`full text items: foo{'@'}domain.com 1`] = `
     "items": [
       {
         "type": 3,
-        "value": "foo",
       },
       {
         "type": 9,
-        "value": "@",
       },
       {
         "type": 3,
-        "value": "domain.com",
       },
     ],
     "static": "[email protected]",
@@ -32,7 +29,6 @@ exports[`full text message on plural: no apples | one apple | many apples 1`] =
         "items": [
           {
             "type": 3,
-            "value": "no apples",
           },
         ],
         "static": "no apples",
@@ -42,7 +38,6 @@ exports[`full text message on plural: no apples | one apple | many apples 1`] =
         "items": [
           {
             "type": 3,
-            "value": "one apple",
           },
         ],
         "static": "one apple",
@@ -52,7 +47,6 @@ exports[`full text message on plural: no apples | one apple | many apples 1`] =
         "items": [
           {
             "type": 3,
-            "value": "many apples",
           },
         ],
         "static": "many apples",
@@ -73,7 +67,6 @@ exports[`incldue dynamic node in pluarl: no apples | {0} apple | {n} apples 1`]
         "items": [
           {
             "type": 3,
-            "value": "no apples",
           },
         ],
         "static": "no apples",
@@ -141,7 +134,6 @@ exports[`literal only: {'hello world'} 1`] = `
     "items": [
       {
         "type": 9,
-        "value": "hello world",
       },
     ],
     "static": "hello world",
@@ -157,7 +149,6 @@ exports[`text only: hello world 1`] = `
     "items": [
       {
         "type": 3,
-        "value": "hello world",
       },
     ],
     "static": "hello world",