fix: tweak tsconfig and resolve tsc errors

Author: kazupon

e2e/helper.ts

@@ -3,27 +3,28 @@ import { useTestContext } from '../scripts/test-utils'
 
 import type { Page } from 'playwright-core'
 
-export function sleep(delay: number) {
+export function sleep(delay: number): Promise<void> {
   return new Promise(resolve => setTimeout(resolve, delay))
 }
 
 export async function getText(
   page: Page,
   selector: string,
   options?: Parameters<Page['locator']>[1]
-) {
+): Promise<string> {
   return (await page.locator(selector, options).allTextContents())[0]
 }
 
 export async function getData(
   page: Page,
   selector: string,
   options?: Parameters<Page['locator']>[1]
-) {
+  // eslint-disable-next-line @typescript-eslint/no-explicit-any
+): Promise<any> {
   return JSON.parse(await page.locator(selector, options).innerText())
 }
 
-export async function assetLocaleHead(page: Page, headSelector: string) {
+export async function assetLocaleHead(page: Page, headSelector: string): Promise<void> {
   const localeHeadValue = await getData(page, headSelector)
   const headHandle = await page.locator('head').elementHandle()
   await page.evaluateHandle(
@@ -47,15 +48,16 @@ export async function assetLocaleHead(page: Page, headSelector: string) {
   await headHandle?.dispose()
 }
 
-export function getDom(html: string) {
+export function getDom(html: string): Document {
   return new JSDOM(html).window.document
 }
 
-export function getDataFromDom(dom: Document, selector: string) {
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
+export function getDataFromDom(dom: Document, selector: string): any {
   return JSON.parse(dom.querySelector(selector)!.textContent!.replace('&quot;', '"'))
 }
 
-export function assertLocaleHeadWithDom(dom: Document, headSelector: string) {
+export function assertLocaleHeadWithDom(dom: Document, headSelector: string): void {
   const localeHead = getDataFromDom(dom, headSelector)
   const headData = [...localeHead.link, ...localeHead.meta]
   for (const head of headData) {
@@ -73,7 +75,7 @@ export function assertLocaleHeadWithDom(dom: Document, headSelector: string) {
   }
 }
 
-export function url(path: string) {
+export function url(path: string): string {
   // eslint-disable-next-line vue-composable/composable-placement -- NOTE(kazupon): not a composable
   const ctx = useTestContext()
 

knip.config.ts

@@ -1,6 +1,6 @@
 import type { KnipConfig } from 'knip'
 
-export default {
+const config: KnipConfig = {
   workspaces: {
     '.': {
       entry: ['scripts/*.ts'],
@@ -56,4 +56,6 @@ export default {
   },
   ignoreDependencies: ['lint-staged', 'mitata'],
   ignoreBinaries: ['tail']
-} satisfies KnipConfig
+}
+
+export default config

package.json

@@ -80,7 +80,8 @@
     "test": "pnpm test:cover && pnpm check-install && pnpm test:e2e",
     "test:cover": "pnpm test:unit --coverage",
     "test:e2e": "cross-env TZ=UTC vitest run -c ./vitest.e2e.config.ts",
-    "test:unit": "cross-env TZ=UTC vitest run -c ./vitest.unit.config.ts --typecheck"
+    "test:unit": "cross-env TZ=UTC vitest run -c ./vitest.unit.config.ts --typecheck",
+    "typecheck": "tsc --noEmit --diagnostics"
   },
   "peerDependencies": {
     "@microsoft/api-extractor": "7.15.2",

packages/core-base/src/runtime.ts

@@ -271,7 +271,7 @@ export interface MessageContext<T = string> {
 }
 
 const DEFAULT_MODIFIER = (str: string): string => str
-const DEFAULT_MESSAGE = (ctx: MessageContext<string>): string => '' // eslint-disable-line
+const DEFAULT_MESSAGE = (_ctx: MessageContext<string>): string => ''
 export const DEFAULT_MESSAGE_DATA_TYPE = 'text'
 const DEFAULT_NORMALIZE = (values: string[]): string => (values.length === 0 ? '' : join(values))
 const DEFAULT_INTERPOLATE = toDisplayString

packages/core-base/test/fixtures/ast.ts

@@ -123,4 +123,4 @@ export const ast = {
       static: 'Product test type'
     }
   }
-}
+} as const

packages/message-compiler/src/transformer.ts

@@ -1,7 +1,7 @@
-import { NodeTypes } from './nodes'
 import { HelperNameMap } from './helpers'
+import { NodeTypes } from './nodes'
 
-import type { ResourceNode, Node, PluralNode, MessageNode, LinkedNode } from './nodes'
+import type { LinkedNode, MessageNode, Node, PluralNode, ResourceNode } from './nodes'
 import type { TransformOptions } from './options'
 
 // TODO: if we offer custom transform for uses, should be defined TransformOptions type to here
@@ -19,10 +19,7 @@ type Transformer = Readonly<{
   helper(name: string): string
 }>
 
-function createTransformer(
-  ast: ResourceNode,
-  options: TransformOptions = {} // eslint-disable-line
-): Transformer {
+function createTransformer(ast: ResourceNode, _options: TransformOptions = {}): Transformer {
   const _context = {
     ast,
     helpers: new Set()
@@ -75,10 +72,7 @@ function traverseNode(node: Node, transformer: Transformer): void {
 }
 
 // transform AST
-export function transform(
-  ast: ResourceNode,
-  options: TransformOptions = {} // eslint-disable-line
-): void {
+export function transform(ast: ResourceNode, _options: TransformOptions = {}): void {
   const transformer = createTransformer(ast)
   transformer.helper(HelperNameMap.NORMALIZE)
 

packages/message-compiler/test/generator.test.ts

@@ -1,12 +1,12 @@
 /* eslint-disable no-irregular-whitespace */
 
 import { format } from '@intlify/shared'
-import { createParser } from '../src/parser'
-import { transform } from '../src/transformer'
+import { SourceMapConsumer } from 'source-map-js'
+import { CompileErrorCodes, errorMessages } from '../src/errors'
 import { generate } from '../src/generator'
+import { createParser } from '../src/parser'
 import { CHAR_CR, CHAR_LF, CHAR_LS, CHAR_PS } from '../src/scanner'
-import { CompileErrorCodes, errorMessages } from '../src/errors'
-import { SourceMapConsumer } from 'source-map-js'
+import { transform } from '../src/transformer'
 
 import type { RawSourceMap } from 'source-map-js'
 import type { ResourceNode } from '../src/nodes'
@@ -17,6 +17,7 @@ interface Pos {
   name?: string
 }
 
+// @ts-ignore -- NOTE(kazupon): keep unused function, because it will be used in future
 // eslint-disable-next-line @typescript-eslint/no-unused-vars
 function getPositionInCode(code: string, token: string, expectName: string | boolean = false): Pos {
   const generatedOffset = code.indexOf(token)

packages/message-compiler/test/helper.ts

@@ -1,8 +1,8 @@
 import { NodeTypes } from '../src/nodes'
 
-import type { Node, PluralNode, MessageNode, LinkedNode } from '../src/nodes'
+import type { LinkedNode, MessageNode, Node, PluralNode } from '../src/nodes'
 
-export function traverse(node: Node, fn: (node: Node) => void) {
+export function traverse(node: Node, fn: (node: Node) => void): void {
   fn(node)
   if (node.type === NodeTypes.Plural) {
     ;(node as PluralNode).cases.forEach(c => traverse(c, fn))

packages/shared/src/utils.ts

@@ -40,7 +40,7 @@ export function format(message: string, ...args: any): string {
   if (!args || !args.hasOwnProperty) {
     args = {}
   }
-  return message.replace(RE_ARGS, (match: string, identifier: string): string => {
+  return message.replace(RE_ARGS, (_match: string, identifier: string): string => {
     return args.hasOwnProperty(identifier) ? args[identifier] : ''
   })
 }

packages/vue-i18n-core/test/components/DatetimeFormat.test.ts

@@ -124,7 +124,7 @@ test('component', async () => {
   })
 
   const MyComponent = defineComponent({
-    setup(props, context: SetupContext) {
+    setup(_props, context: SetupContext) {
       return (): VNodeChild => h('span', context.slots.default!())
     }
   })