Skip to content

Commit d9ce770

Browse files
fix won't fallback when fallbackLocale is empty string, and add a test (#330)
1 parent 40c4344 commit d9ce770

File tree

2 files changed

+5
-5
lines changed

2 files changed

+5
-5
lines changed

packages/core-base/src/context.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -353,14 +353,10 @@ export function handleMissing<Message = string>(
353353
export function getLocaleChain<Message = string>(
354354
ctx: CoreCommonContext<Message>,
355355
fallback: FallbackLocale,
356-
start: Locale = ''
356+
start: Locale
357357
): Locale[] {
358358
const context = (ctx as unknown) as CoreInternalContext
359359

360-
if (start === '') {
361-
return []
362-
}
363-
364360
if (!context.__localeChainCache) {
365361
context.__localeChainCache = new Map()
366362
}

packages/core-base/test/context.test.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,10 @@ describe('getLocaleChain', () => {
204204
})
205205

206206
describe(`simple: 'en'`, () => {
207+
test('empty string', () => {
208+
expect(getLocaleChain(ctx, 'en', '')).toEqual(['en'])
209+
})
210+
207211
test('en', () => {
208212
expect(getLocaleChain(ctx, 'en', 'en')).toEqual(['en'])
209213
})

0 commit comments

Comments
 (0)