feat(shared): sharable symbol (#1261)

Author: kazupon

packages/shared/src/utils.ts

@@ -48,11 +48,8 @@ export function format(message: string, ...args: any): string {
   )
 }
 
-const hasSymbol =
-  typeof Symbol === 'function' && typeof Symbol.toStringTag === 'symbol'
-
-export const makeSymbol = (name: string): symbol | string =>
-  hasSymbol ? Symbol(name) : name
+export const makeSymbol = (name: string, shareable = false): symbol =>
+  !shareable ? Symbol(name) : Symbol.for(name)
 
 export const generateFormatCacheKey = (
   locale: string,

packages/shared/test/utils.test.ts

@@ -1,4 +1,4 @@
-import { format, generateCodeFrame } from '../src/index'
+import { format, generateCodeFrame, makeSymbol } from '../src/index'
 
 test('format', () => {
   expect(format(`foo: {0}`, 'x')).toEqual('foo: x')
@@ -12,3 +12,8 @@ test('generateCodeFrame', () => {
   const keyEnd = keyStart + `{ 'kazupon' }`.length
   expect(generateCodeFrame(source, keyStart, keyEnd)).toMatchSnapshot()
 })
+
+test('makeSymbol', () => {
+  expect(makeSymbol('foo')).not.toEqual(makeSymbol('foo'))
+  expect(makeSymbol('bar', true)).toEqual(makeSymbol('bar', true))
+})