Skip to content

Conversation

@babu-ch
Copy link
Contributor

@babu-ch babu-ch commented Feb 15, 2025

closes #2101

By the way, is docs/.ja not used?
If so, would you like me to remove it from this PR?
When I grep with cjs, it gets matched

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to remove for cjs, but vue-i18n docs have to support v9 - v12.
So, We need to mention for cjs dropping on v12 as important tip.

@kazupon
Copy link
Member

kazupon commented Feb 16, 2025

Thank you for your contribution!

I have one more favor to ask 🙏
We want to ship vue-i18n dist files as .js, not .mjs.
Let's try to work on it. 😉

@kazupon kazupon added the Type: Breaking Includes backwards-incompatible fixes label Feb 16, 2025
@kazupon kazupon changed the title drop cjs ship ESM only Feb 16, 2025
@github-actions
Copy link

github-actions bot commented Feb 16, 2025

Size Report

Bundles

File Size Gzip Brotli
core.esm-browser.prod.js 37.16 kB 11.35 kB 10.12 kB
core.global.prod.js 30.50 kB 10.55 kB 9.52 kB
core.runtime.esm-browser.prod.js 22.87 kB 7.45 kB 6.65 kB
core.runtime.global.prod.js 17.48 kB 6.81 kB 6.12 kB
message-compiler.esm-browser.prod.js 19.28 kB 5.76 kB 5.14 kB
message-compiler.global.prod.js 17.32 kB 5.54 kB 4.97 kB
petite-vue-i18n-core.esm-browser.prod.js 20.13 kB 6.76 kB 6.08 kB
petite-vue-i18n-core.global.prod.js 15.40 kB 5.96 kB 5.40 kB
petite-vue-i18n.esm-browser.prod.js 36.62 kB 11.24 kB 10.09 kB
petite-vue-i18n.global.prod.js 29.63 kB 10.09 kB 9.12 kB
petite-vue-i18n.runtime.esm-browser.prod.js 22.19 kB 7.23 kB 6.53 kB
petite-vue-i18n.runtime.global.prod.js 16.63 kB 6.32 kB 5.73 kB
vue-i18n.esm-browser.prod.js 50.23 kB 15.02 kB 13.44 kB
vue-i18n.global.prod.js 40.28 kB 13.49 kB 12.15 kB
vue-i18n.runtime.esm-browser.prod.js 35.80 kB 11.03 kB 9.92 kB
vue-i18n.runtime.global.prod.js 27.26 kB 9.76 kB 8.83 kB
core.prod.cjs
message-compiler.prod.cjs
petite-vue-i18n-core.prod.cjs
petite-vue-i18n.prod.cjs
vue-i18n.prod.cjs

Usages

Name Size Gzip Brotli
packages/size-check-core (@intlify/core) 9.10 kB 3.76 kB 3.41 kB
packages/size-check-petite-vue-i18n (petite-vue-i18n) 77.58 kB 30.23 kB 27.24 kB
packages/size-check-vue-i18n (vue-i18n) 82.59 kB 31.65 kB 28.44 kB

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 16, 2025

Open in Stackblitz

@intlify/core

npm i https://pkg.pr.new/@intlify/core@2112

@intlify/core-base

npm i https://pkg.pr.new/@intlify/core-base@2112

@intlify/devtools-types

npm i https://pkg.pr.new/@intlify/devtools-types@2112

@intlify/message-compiler

npm i https://pkg.pr.new/@intlify/message-compiler@2112

petite-vue-i18n

npm i https://pkg.pr.new/petite-vue-i18n@2112

@intlify/shared

npm i https://pkg.pr.new/@intlify/shared@2112

vue-i18n

npm i https://pkg.pr.new/vue-i18n@2112

@intlify/vue-i18n-core

npm i https://pkg.pr.new/@intlify/vue-i18n-core@2112

commit: 8272b1c

@kazupon
Copy link
Member

kazupon commented Feb 16, 2025

And, We need to find out about code size increasing
#2112 (comment)

@kazupon
Copy link
Member

kazupon commented Feb 16, 2025

By the way, is docs/.ja not used?

Ah, sorry.
docs/.ja is not maintained, so you can remove another PR.

@babu-ch babu-ch mentioned this pull request Feb 17, 2025
@babu-ch
Copy link
Contributor Author

babu-ch commented Feb 17, 2025

@kazupon

We want to ship vue-i18n dist files as .js, not .mjs.

Fixed in commit
5c725d4

@babu-ch
Copy link
Contributor Author

babu-ch commented Feb 17, 2025

@kazupon

And, We need to find out about code size increasing

Maybe it was because I was working on an old branch
merged the latest

@kazupon
Copy link
Member

kazupon commented Feb 19, 2025

@babu-ch
Well done!
Perfect! 💯

Thank you so much!

@kazupon kazupon merged commit 56ffe24 into intlify:master Feb 19, 2025
28 checks passed
@babu-ch babu-ch deleted the drop_cjs branch September 7, 2025 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Type: Breaking Includes backwards-incompatible fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ship ESM only

2 participants