Tweaks to work with Mantis v2

Author: samiraguiar

IssuesDiff.php

@@ -18,7 +18,7 @@ public function register() {
 
         $this->version = "1.0";
         $this->requires = array(
-            "MantisCore" => "1.2.11",
+            "MantisCore" => "2.5.0",
         );
 
         $this->author = "Samir Aguiar";
@@ -28,25 +28,17 @@ public function register() {
 
     public function hooks() {
         return array(
-            "EVENT_MENU_ISSUE" => "get_menu_option",
             "EVENT_VIEW_BUG_DETAILS" => "inject_script"
         );
     }
 
     public function inject_script() {
-        $plugin_basename = plugin_get_current();
-        $script_path = plugin_file_path('js/add_diff_view_link.js', $plugin_basename);
-        $script_contents = file_get_contents($script_path);
-
         $menu_title = plugin_lang_get("menu_title");
         $diff_page_url = plugin_page("bug_revision_diff_page", true);
 
-        $script = "(function() {" .
-                    "var linkText = '$menu_title';" .
-                    "var diffPageUrl = '$diff_page_url';" .
-                    $script_contents .
-                  "})();";
+        echo '<a id="view-diff-anchor" data-base-href="'
+             . $diff_page_url . '" style="display: none">' . $menu_title . '</a>';
 
-        echo "<script> $script </script>";
+        echo '<script src="' . plugin_file('js/add_diff_view_link.js') . '"></script>';
     }
 }

files/css/diff_style.css

@@ -8,7 +8,7 @@ form.diff-form input.diff-form-submit {
 }
 
 .issue-diff-area {
-    background-color: #E8E8E8;
+    background-color: #F9F9F9;
 }
 
 form.diff-form .issue-diff-separator {

files/js/add_diff_view_link.js

@@ -1,57 +1,64 @@
-function appendAnchor(cellElement, bug_view_link) {
-    var anchor = document.createElement("A");
-    anchor.text = linkText;
-    anchor.href = bug_view_link;
+(function() {
+    var baseAnchor = document.getElementById("view-diff-anchor");
+    var diffPageUrl = baseAnchor.getAttribute('data-base-href');
 
-    cellElement.appendChild(getSplitter());
-    cellElement.appendChild(anchor);
-}
+    baseAnchor.removeAttribute('id');
+    baseAnchor.removeAttribute('data-base-href');
 
-function getSplitter() {
-    var span = document.createElement("SPAN");
-    span.innerHTML = " | "
+    function appendAnchor(cellElement, bug_view_link) {
+        var anchor = $.clone(baseAnchor);
+        anchor.href = bug_view_link;
+        anchor.style.display = 'inline';
 
-    return span;
-}
+        cellElement.appendChild(getSplitter());
+        cellElement.appendChild(anchor);
+    }
 
-function getQueryString(url) {
-    var questionMarkIndex = url.indexOf('?');
+    function getSplitter() {
+        var span = document.createElement("SPAN");
+        span.innerHTML = " | "
 
-    if (questionMarkIndex === -1) return '';
+        return span;
+    }
 
-    var newUrl = url.slice(questionMarkIndex + 1).replace("#r", "&last=");
+    function getQueryString(url) {
+        var questionMarkIndex = url.indexOf('?');
 
-    return '&' + newUrl;
-}
+        if (questionMarkIndex === -1) return '';
 
-function addDiffViewLink() {
-    var issueHistory = document.getElementById("history_open");
+        var newUrl = url.slice(questionMarkIndex + 1).replace("#r", "&last=");
 
-    var rows = issueHistory.getElementsByTagName("tr");
+        return '&' + newUrl;
+    }
 
-    for (var i = 0; i < rows.length; i++) {
-        var changeCell = rows[i].lastElementChild;
+    function addDiffViewLink() {
+        var issueHistory = $("#history tbody");
+        var rows = issueHistory[0].getElementsByTagName("tr");
 
-        if (!changeCell) continue;
+        for (var i = 0; i < rows.length; i++) {
+            var changeCell = rows[i].lastElementChild;
 
-        var cellAnchor = changeCell.getElementsByTagName("a");
+            if (!changeCell) continue;
 
-        if (!cellAnchor.length) continue;
+            var cellAnchor = changeCell.getElementsByTagName("a");
 
-        var revisionUrl = cellAnchor[0].getAttribute("href");
+            if (!cellAnchor.length) continue;
 
-        if (revisionUrl.indexOf("bug_revision_view_page") === -1) {
-            continue;
-        }
+            var revisionUrl = cellAnchor[0].getAttribute("href");
 
-        var queryString = getQueryString(revisionUrl);
+            if (revisionUrl.indexOf("bug_revision_view_page") === -1) {
+                continue;
+            }
 
-        appendAnchor(changeCell, diffPageUrl + queryString);
+            var queryString = getQueryString(revisionUrl);
+
+            appendAnchor(changeCell, diffPageUrl + queryString);
+        }
     }
-}
 
-if (window.addEventListener){
-    window.addEventListener('load', addDiffViewLink)
-} else{
-    window.attachEvent('onload', addDiffViewLink)
-}
+    if (window.addEventListener){
+        window.addEventListener('load', addDiffViewLink)
+    } else{
+        window.attachEvent('onload', addDiffViewLink)
+    }
+})();