Perform update check in a separate thread (task)

Author: introfog

src/main/java/com/github/introfog/gitwave/controller/main/MenuController.java

@@ -8,6 +8,7 @@
 import com.github.introfog.gitwave.model.UpdateChecker;
 
 import java.io.File;
+import javafx.concurrent.Task;
 import javafx.scene.control.Menu;
 import javafx.scene.control.MenuItem;
 import javafx.scene.control.SeparatorMenuItem;
@@ -16,22 +17,16 @@
 
 public class MenuController extends SupportController {
     private static final Logger LOGGER = LoggerFactory.getLogger(MenuController.class);
-    private Menu menu;
-    private MenuItem updateMenuItem;
-    private SeparatorMenuItem updateMenuItemSeparator;
+    private final Menu menu;
+    private final MenuItem updateMenuItem;
+    private final SeparatorMenuItem updateMenuItemSeparator;
 
     public MenuController(FxmlStageHolder fxmlStageHolder, Menu menu, MenuItem updateMenuItem, SeparatorMenuItem updateMenuItemSeparator) {
         super(fxmlStageHolder);
         this.menu = menu;
         this.updateMenuItem = updateMenuItem;
         this.updateMenuItemSeparator = updateMenuItemSeparator;
-        if (UpdateChecker.isNewReleaseAvailable()) {
-            this.menu.setText("Menu*");
-            this.updateMenuItem.setDisable(false);
-            this.updateMenuItem.setVisible(true);
-            this.updateMenuItemSeparator.setDisable(false);
-            this.updateMenuItemSeparator.setVisible(true);
-        }
+        new Thread(createCheckForUpdateTask()).start();
     }
 
     @Override
@@ -60,4 +55,24 @@ public void openAbout() {
     public void openUpdate() {
         StageFactory.createModalUpdateWindow().getStage().showAndWait();
     }
+
+    private Task<Boolean> createCheckForUpdateTask() {
+        Task<Boolean> checkForUpdate = new Task<>() {
+            @Override
+            protected Boolean call() {
+                return UpdateChecker.isNewReleaseAvailable();
+            }
+        };
+        checkForUpdate.setOnSucceeded((e) -> {
+            boolean isNewReleaseAvailable = checkForUpdate.getValue();
+            if (isNewReleaseAvailable) {
+                this.menu.setText("Menu*");
+                this.updateMenuItem.setDisable(false);
+                this.updateMenuItem.setVisible(true);
+                this.updateMenuItemSeparator.setDisable(false);
+                this.updateMenuItemSeparator.setVisible(true);
+            }
+        });
+        return checkForUpdate;
+    }
 }

src/main/java/com/github/introfog/gitwave/model/UpdateChecker.java

@@ -36,7 +36,6 @@ private UpdateChecker() {
     }
 
     public static boolean isNewReleaseAvailable() {
-        // TODO MINOR fetch and check update in the separate thread, to quicker open app.
         final String latestTag = fetchLatestTag(AppConstants.GIT_HUB_REPO_OWNER, AppConstants.APP_NAME);
         LOGGER.info("Fetch '{}' tag from GitHub repo.", latestTag);
         return latestTag != null && !AppConstants.VERSION.equals(latestTag);