Skip to content

Commit c27585d

Browse files
committed
Fix project packaging by using local modularized richtextfx fat jar
1 parent 4b6413d commit c27585d

File tree

4 files changed

+11
-5
lines changed

4 files changed

+11
-5
lines changed

.gitignore

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,8 +36,10 @@ target/
3636
# GitWave util folders
3737
logs/
3838
config/
39-
temp/
4039

41-
# GitWave executor peojct
40+
# GitWave executor projct
4241
tools/GitWaveExecutor/.vs/
43-
tools/GitWaveExecutor/GitWaveExecutor/x64/
42+
tools/GitWaveExecutor/GitWaveExecutor/x64/
43+
44+
# GitWave richtextfx fat jar
45+
!/tools/richtextfx-fat-*.jar

pom.xml

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,11 @@
4242
<groupId>org.fxmisc.richtext</groupId>
4343
<artifactId>richtextfx</artifactId>
4444
<version>${richtextfx.version}</version>
45+
<!-- Jlink doesn't support work with automatic modules. Transitive dependencies of RichTextFX are not
46+
modularized and no longer maintained (see https://github.com/FXMisc/RichTextFX/issues/902).
47+
So to mitigate that problem local modularized fat jar is used, instead of usual maven central dependency. -->
48+
<scope>system</scope>
49+
<systemPath>${project.basedir}/tools/richtextfx-fat-0.11.3.jar</systemPath>
4550
</dependency>
4651
<dependency>
4752
<groupId>org.slf4j</groupId>

src/main/java/module-info.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -10,8 +10,7 @@
1010
requires com.fasterxml.jackson.databind;
1111
requires com.fasterxml.jackson.annotation;
1212
requires com.fasterxml.jackson.core;
13-
requires org.fxmisc.richtext;
14-
requires org.fxmisc.flowless;
13+
requires richtextfx.fat;
1514

1615
opens com.github.introfog.gitwave to javafx.fxml;
1716
opens com.github.introfog.gitwave.model.dto to com.fasterxml.jackson.core, com.fasterxml.jackson.annotation, com.fasterxml.jackson.databind, javafx.base;

tools/richtextfx-fat-0.11.3.jar

855 KB
Binary file not shown.

0 commit comments

Comments
 (0)