Fix clang warkings

Author: Rouiller

c_plus_plus/src/steno/main.cpp

@@ -7,5 +7,5 @@ int main(int argc, char *argv[])
     QApplication a(argc, argv);
     MainWindow w;
     w.show();
-    return a.exec();
+    return QApplication::exec();
 }

c_plus_plus/src/steno/model/i_media_player.h

@@ -11,24 +11,23 @@ namespace Model
 
 class IMediaPlayer : public QWidget
 {
-    Q_OBJECT
-
-    public:
-        IMediaPlayer(QWidget *parent = nullptr) : QWidget(parent) {}
-        virtual ~IMediaPlayer() {}
-        virtual void setMedia(const QUrl &url) = 0;
-        virtual void play() = 0;
-        virtual void setPosition(int position) = 0;
-        virtual void setVideoOutput(QVideoWidget *videoOutput) = 0;
-        virtual void setVolume(int volume) = 0;
-        virtual int volume() const = 0;
-
-     signals:
-        void stateChanged(QMediaPlayer::State state);
-        void positionChanged(qint64 position);
-        void durationChanged(qint64 duration);
-        void volumeChanged(int volume);
-        void errorOccured(QString error);
+Q_OBJECT
+
+public:
+    IMediaPlayer(QWidget *parent = nullptr) : QWidget(parent) {}
+    virtual void setMedia(const QUrl &url) = 0;
+    virtual void play() = 0;
+    virtual void setPosition(int position) = 0;
+    virtual void setVideoOutput(QVideoWidget *videoOutput) = 0;
+    virtual void setVolume(int volume) = 0;
+    virtual int volume() const = 0;
+
+signals:
+    void stateChanged(QMediaPlayer::State state);
+    void positionChanged(qint64 position);
+    void durationChanged(qint64 duration);
+    void volumeChanged(int volume);
+    void errorOccured(const QString& error);
 };
 
 } // Model

c_plus_plus/src/steno/model/media_player.cpp

@@ -17,11 +17,6 @@ MediaPlayer::MediaPlayer(QWidget *parent)
     connect(m_mediaPlayer, QOverload<QMediaPlayer::Error>::of(&QMediaPlayer::error), [=]{ onErrorOccured(); });
 }
 
-MediaPlayer::~MediaPlayer()
-{
-    delete m_mediaPlayer;
-}
-
 void MediaPlayer::setVideoOutput(QVideoWidget *videoOutput)
 {
     m_mediaPlayer->setVideoOutput(videoOutput);

c_plus_plus/src/steno/model/media_player.h

@@ -13,20 +13,19 @@ namespace Model
 
 class MediaPlayer : public IMediaPlayer
 {
-    public:
-        explicit MediaPlayer(QWidget *parent = nullptr);
-        virtual ~MediaPlayer() override;
-        virtual void setMedia(const QUrl &url) override;
-        virtual void play() override;
-        virtual void setPosition(int position) override;
-        virtual void setVideoOutput(QVideoWidget *videoOutput) override;
-        virtual void setVolume(int volume) override;
-        virtual int volume() const override;
-
-    private:
-        void onErrorOccured();
-
-        QMediaPlayer* m_mediaPlayer;
+public:
+    explicit MediaPlayer(QWidget *parent = nullptr);
+    void setMedia(const QUrl &url) override;
+    void play() override;
+    void setPosition(int position) override;
+    void setVideoOutput(QVideoWidget *videoOutput) override;
+    void setVolume(int volume) override;
+    int volume() const override;
+
+private:
+    void onErrorOccured();
+
+    QMediaPlayer* m_mediaPlayer;
 };
 
 } // Model

c_plus_plus/src/steno/view/components/sidebar.cpp

@@ -5,18 +5,18 @@ namespace View
 
 SideBar::SideBar(QWidget *parent)
     : QListWidget(parent)
-    , itemSize(QSize(0, 40))
+    , m_itemSize(0, m_itemHeight)
 {
-    setFixedWidth(150);
+    setFixedWidth(m_itemWidth);
 }
 
-void SideBar::add(QString name)
+void SideBar::add(const QString& name)
 {
     addItem(name);
 
     for (int i = 0; i < count(); i++)
     {
-        item(i)->setSizeHint(itemSize);
+        item(i)->setSizeHint(m_itemSize);
     }
 }
 

c_plus_plus/src/steno/view/components/sidebar.h

@@ -8,15 +8,17 @@ namespace View
 
 class SideBar : public QListWidget
 {
-    Q_OBJECT
+Q_OBJECT
 
-    public:
-        SideBar(QWidget *parent = nullptr);
+public:
+    SideBar(QWidget *parent = nullptr);
 
-        void add(QString name);
+    void add(const QString& name);
 
-    private:
-        const QSize itemSize;
+private:
+    const uint8_t m_itemHeight = 40;
+    const uint8_t m_itemWidth = 150;
+    const QSize m_itemSize;
 };
 
 } // View

c_plus_plus/src/steno/view/mainwindow.cpp

@@ -27,12 +27,12 @@ MainWindow::MainWindow(QWidget *parent)
 {
     ui->setupUi(this);
 
-    Model::MediaPlayer *mediaPlayer = new Model::MediaPlayer();
+    auto mediaPlayer = new Model::MediaPlayer();
     mediaPlayerView = new View::MediaPlayerView(*mediaPlayer);
 
     QFile File("view/stylesheets/globalStylesheet.qss");
     File.open(QFile::ReadOnly);
-    qApp->setStyleSheet(QLatin1String(File.readAll()));
+    this->setStyleSheet(QLatin1String(File.readAll()));
 
     addView(conferenceView);
     addView(recordingView);
@@ -54,8 +54,3 @@ void MainWindow::addView(View::AbstractView *view)
     sideBar->add(view->getName());
     views->addWidget(view);
 }
-
-MainWindow::~MainWindow()
-{
-    delete ui;
-}

c_plus_plus/src/steno/view/mainwindow.h

@@ -12,23 +12,22 @@ namespace View { class SideBar;
 
 class MainWindow : public QMainWindow
 {
-    Q_OBJECT
-
-    public:
-        MainWindow(QWidget *parent = nullptr);
-        virtual ~MainWindow();
-
-    private:
-        void addView(View::AbstractView *view);
-
-        Ui::MainWindow *ui;
-        View::SideBar *sideBar;
-        QStackedWidget *views;
-        View::AbstractView *conferenceView;
-        View::AbstractView *recordingView;
-        View::AbstractView *mediaPlayerView;
-        View::AbstractView *transcriptionView;
-        View::AbstractView *settingsView;
+Q_OBJECT
+
+public:
+    MainWindow(QWidget *parent = nullptr);
+
+private:
+    void addView(View::AbstractView *view);
+
+    Ui::MainWindow *ui;
+    View::SideBar *sideBar;
+    QStackedWidget *views;
+    View::AbstractView *conferenceView;
+    View::AbstractView *recordingView;
+    View::AbstractView *mediaPlayerView;
+    View::AbstractView *transcriptionView;
+    View::AbstractView *settingsView;
 };
 
 #endif // MAINWINDOW_H

c_plus_plus/src/steno/view/views/abstract_view.h

@@ -1,26 +1,27 @@
 #ifndef ABSTRACT_VIEW_H
 #define ABSTRACT_VIEW_H
 
+#include <utility>
+
 #include <QWidget>
 
 namespace View
 {
 
 class AbstractView : public QWidget
 {
-    Q_OBJECT
-
-    public:
+Q_OBJECT
 
-        explicit AbstractView(const QString &name, QWidget *parent)
-            : QWidget(parent)
-            , name(name)
-        {}
+public:
+    explicit AbstractView(QString name, QWidget *parent)
+        : QWidget(parent)
+        , name(std::move(name))
+    {}
 
-        const QString& getName() {return name;}
+    const QString& getName() {return name;}
 
-    private:
-        QString name;
+private:
+    QString name;
 };
 
 } // View

c_plus_plus/src/steno/view/views/conference_view.cpp

@@ -11,9 +11,4 @@ ConferenceView::ConferenceView(QWidget *parent)
     ui->setupUi(this);
 }
 
-ConferenceView::~ConferenceView()
-{
-    delete ui;
-}
-
 } // View