Improve test coverage

Author: Christopher Wall

schema/src/test/java/com/introproventures/graphql/jpa/query/support/GraphQLExecutorTestsSupport.java

@@ -581,6 +581,87 @@ public void queryAuthorBooksWithExplictOptionalNotLikeConjunction() {
         assertThat(result.toString()).isEqualTo(expected);
     }
 
+    @Test
+    public void queryAuthorBooksWithNotOutsideOfLikeDisjunction() {
+        //should be the same result as queryAuthorBooksWithExplictOptionalNotLikeConjunction above
+        //due to logical inversion AND(Not Like A, Not Like B) => NOT(OR(Like a, Like b))
+        //given
+        String query =
+            "query { " +
+            "Authors(" +
+            "    where: {" +
+            "      books: {" +
+            "        NOT: {OR: [{title: {LIKE: \"War\"}} {title: {LIKE: \"Anna\"}}]}" +
+            "      }" +
+            "    }" +
+            "  ) {" +
+            "    select {" +
+            "      id" +
+            "      name" +
+            "      books(optional: true) {" +
+            "        id" +
+            "        title(orderBy: ASC)" +
+            "        genre" +
+            "      }" +
+            "    }" +
+            "  }" +
+            "}";
+
+        String expected =
+            "{Authors={select=[" +
+            "{id=4, name=Anton Chekhov, books=[" +
+            "{id=5, title=The Cherry Orchard, genre=PLAY}, " +
+            "{id=6, title=The Seagull, genre=PLAY}, " +
+            "{id=7, title=Three Sisters, genre=PLAY}" +
+            "]}" +
+            "]}}";
+
+        //when
+        Object result = executor.execute(query).getData();
+
+        // then
+        assertThat(result.toString()).isEqualTo(expected);
+    }
+
+    @Test
+    public void queryAuthorBooksWithNotOutsideOfConjunction() {
+        //given
+        String query =
+            "query { " +
+            "Authors(" +
+            "    where: {" +
+            "      books: {" +
+            "        NOT: {AND: [{id: {GE: 4}} {genre: {EQ: PLAY}}]}" +
+            "      }" +
+            "    }" +
+            "  ) {" +
+            "    select {" +
+            "      id" +
+            "      name" +
+            "      books(optional: true) {" +
+            "        id" +
+            "        title(orderBy: ASC)" +
+            "        genre" +
+            "      }" +
+            "    }" +
+            "  }" +
+            "}";
+
+        String expected =
+            "{Authors={select=[" +
+            "{id=1, name=Leo Tolstoy, books=[" +
+            "{id=3, title=Anna Karenina, genre=NOVEL}, " +
+            "{id=2, title=War and Peace, genre=NOVEL}" +
+            "]}" +
+            "]}}";
+
+        //when
+        Object result = executor.execute(query).getData();
+
+        // then
+        assertThat(result.toString()).isEqualTo(expected);
+    }
+
     @Test
     public void queryAuthorBooksWithExplictOptionalEXISTS() {
         //given
@@ -620,6 +701,51 @@ public void queryAuthorBooksWithExplictOptionalEXISTS() {
         assertThat(result.toString()).isEqualTo(expected);
     }
 
+    @Test
+    public void queryAuthorBooksWithExplictOptionalNotEXISTS() {
+        //given
+        String query =
+            "query { " +
+            "Authors(" +
+            "    where: {" +
+            "      NOT: {" +
+            "        EXISTS: {" +
+            "          books: {" +
+            "            title: {LIKE: \"War\"}" +
+            "          }" +
+            "        }" +
+            "      }" +
+            "    }" +
+            "  ) {" +
+            "    select {" +
+            "      id" +
+            "      name" +
+            "      books(optional: true) {" +
+            "        id" +
+            "        title(orderBy: ASC)" +
+            "        genre" +
+            "      }" +
+            "    }" +
+            "  }" +
+            "}";
+
+        String expected =
+            "{Authors={select=[" +
+            "{id=4, name=Anton Chekhov, books=[" +
+            "{id=5, title=The Cherry Orchard, genre=PLAY}," +
+            " {id=6, title=The Seagull, genre=PLAY}," +
+            " {id=7, title=Three Sisters, genre=PLAY}" +
+            "]}, " +
+            "{id=8, name=Igor Dianov, books=[]}" +
+            "]}}";
+
+        //when
+        Object result = executor.execute(query).getData();
+
+        // then
+        assertThat(result.toString()).isEqualTo(expected);
+    }
+
     @Test
     public void queryAuthorBooksWithCollectionOrderBy() {
         //given
@@ -2169,6 +2295,22 @@ public void ignoreOrder() {
             .contains(ErrorType.ValidationError, Arrays.asList("Books", "select", "description"));
     }
 
+    @Test
+    public void logicalNotOnlySupportsSingleOperand() {
+        //given
+        String query = "{ Books(where: {NOT: [{id: {EQ: 1}} {id: {EQ: 2}}]}){ select { id description } }}";
+
+        List<GraphQLError> result = executor.execute(query).getErrors();
+
+        //then
+        assertThat(result).hasSize(1);
+        assertThat(result.get(0))
+            .isExactlyInstanceOf(ValidationError.class)
+            .extracting(ValidationError.class::cast)
+            .extracting("errorType", "queryPath")
+            .contains(ErrorType.ValidationError, Arrays.asList("Books"));
+    }
+
     @Test
     public void titleOrder() {
         //given