Skip to content

Commit 89a47d9

Browse files
committed
Updates for signing assembly and removing unused code
1 parent b7a203c commit 89a47d9

File tree

2 files changed

+12
-22
lines changed

2 files changed

+12
-22
lines changed

IPPDotNetDevKitCSV3/Code/Intuit.Ipp.Core/Configuration/JsonFileConfigurationProvider.cs

Lines changed: 1 addition & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -54,28 +54,7 @@ public JsonFileConfigurationProvider(string path)
5454
builder = new ConfigurationBuilder()
5555
.AddJsonFile(path, optional: true)
5656
.Build();
57-
//var builder = new ConfigurationBuilder()
58-
// .AddJsonFile(path)
59-
// .Build();
60-
61-
//// First way
62-
//string value1 = _iconfiguration.GetSection("Data").GetSection("ConnectionString").Value;
63-
//// Second way
64-
//string value2 = _iconfiguration.GetValue<string>("Data:ConnectionString");
65-
66-
67-
//var apiSettings = builder.GetSection("Logger").GetSection("RequestLog");
68-
69-
////var enableLogs = apiSettings["EnableLogs"];
70-
//logPath = apiSettings["LogDirectory"];
71-
//LogPath = LogDirectory.ToString();
72-
73-
//if (!Enum.TryParse(apiSettings["AppType"], true, out XeroApiAppType appType))
74-
//{
75-
// throw new ArgumentOutOfRangeException(nameof(apiSettings), apiSettings["AppType"], "AppType did not match one of: private, public, partner");
76-
//}
77-
78-
//AppType = appType;
57+
7958

8059

8160
}

IPPDotNetDevKitCSV3/Code/Intuit.Ipp.Nupkg/Intuit.Ipp.Nupkg.csproj

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -142,4 +142,15 @@
142142
</TfmSpecificPackageFile>
143143
</ItemGroup>
144144
</Target>
145+
146+
<!--code for signing-->
147+
<!--<PropertyGroup>
148+
<SignToolPath>C:\Program Files (x86)\Windows Kits\10\bin\10.0.17763.0\x64\signtool.exe</SignToolPath>
149+
<SigningCertificateSubjectName>your-subject</SigningCertificateSubjectName>
150+
</PropertyGroup>
151+
152+
<Target Name="SignAssembly" DependsOnTargets="Build">
153+
<Message Text="Signing assembly '$(TargetDir)$(TargetFileName)'" Importance="high"/>
154+
<Exec Command="&quot;$(SignToolPath)&quot; sign /n &quot;$(SigningCertificateSubjectName)&quot; &quot;$(TargetDir)$(TargetFileName)&quot;"/>
155+
</Target>-->
145156
</Project>

0 commit comments

Comments
 (0)