Merge pull request #363 from sujitharamadass/Webhooks

Batch item limit updated to 30

Author: sujitharamadass

IPPDotNetDevKitCSV3/Code/Directory.Build.props

@@ -14,8 +14,8 @@
 		<PackageIcon>$(MSBuildThisFileDirectory)logo.png</PackageIcon>
 		<OutputPath>$(SolutionDir)artifacts\bin</OutputPath>
 		<Copyright>Copyright © 2020 Intuit, Inc.</Copyright>
-		<AssemblyVersion>14.7.0.2</AssemblyVersion>
-		<FileVersion>14.7.0.2</FileVersion>
+		<AssemblyVersion>14.7.0.3</AssemblyVersion>
+		<FileVersion>14.7.0.3</FileVersion>
 		<Company>Intuit</Company>
 		<AppendTargetFrameworkToOutputPath>true</AppendTargetFrameworkToOutputPath>
 		<AppendRuntimeIdentifierToOutputPath>false</AppendRuntimeIdentifierToOutputPath>

IPPDotNetDevKitCSV3/Code/Intuit.Ipp.DataService.Test/BatchTests.cs

@@ -224,7 +224,7 @@ public void AddNullEntityInBatch()
 
         [TestMethod]
         [ExpectedException(typeof(Intuit.Ipp.Exception.IdsException))]
-        public void AddMoreThanTwentyFiveItemsInBatch()
+        public void AddMoreThanThirtyItemsInBatch()
         {
             ServiceContext context = Initializer.InitializeServiceContextQbo();
             DataService service = new DataService(context);
@@ -266,7 +266,7 @@ public void AddEmptyIdToBatch()
 
         [TestMethod]
         [ExpectedException(typeof(Intuit.Ipp.Exception.IdsException))]
-        public void AddTwentyFivePlusToBatch()
+        public void AddThirtyPlusToBatch()
         {
             Batch batch = GetBatch();
             string queryId = string.Empty;
@@ -322,7 +322,7 @@ public void AddEmptyIdToBatchEntity()
 
         [TestMethod]
         [ExpectedException(typeof(Intuit.Ipp.Exception.IdsException))]
-        public void AddTwentyFivePlusToBatchEntity()
+        public void AddThirtyPlusToBatchEntity()
         {
             Batch batch = GetBatch();
             string queryId = string.Empty;

IPPDotNetDevKitCSV3/Code/Intuit.Ipp.DataService/Batch.cs

@@ -211,7 +211,7 @@ public void Add(string query, string id, List<String> optionsData)
                 IdsExceptionManager.HandleException(exception);
             }
 
-            if (this.batchRequests.Count > 30)
+            if (this.batchRequests.Count >= 30)
             {
                 IdsException exception = new IdsException(Resources.batchItemsExceededMessage, new BatchItemsExceededException(Resources.batchItemsExceededMessage));
                 this.serviceContext.IppConfiguration.Logger.CustomLogger.Log(Diagnostics.TraceLevel.Error, string.Format(CultureInfo.InvariantCulture, Resources.ExceptionGeneratedMessage, exception.ToString()));
@@ -344,7 +344,7 @@ public void Add(IEntity entity, string id, OperationEnum operation, List<String>
                 IdsExceptionManager.HandleException(exception);
             }
 
-            if (this.batchRequests.Count > 30)
+            if (this.batchRequests.Count >= 30)
             {
                 IdsException exception = new IdsException(Resources.batchItemsExceededMessage, new BatchItemsExceededException(Resources.batchItemsExceededMessage));
                 this.serviceContext.IppConfiguration.Logger.CustomLogger.Log(Diagnostics.TraceLevel.Error, string.Format(CultureInfo.InvariantCulture, Resources.ExceptionGeneratedMessage, exception.ToString()));

IPPDotNetDevKitCSV3/Code/Intuit.Ipp.DataService/Properties/Resources.resx

@@ -184,7 +184,7 @@
     <value>string parameter can not be null or empty.</value>
   </data>
   <data name="batchItemsExceededMessage" xml:space="preserve">
-    <value>Number of Items in Batch Request exceeded the permissible limit of 25 items.</value>
+    <value>Number of Items in Batch Request exceeded the permissible limit of 30 items.</value>
   </data>
   <data name="PdfOperationNotSupportedOnEntity" xml:space="preserve">
     <value>Only entitites of type SalesReceipt, Invoice and Estimate are supported for this operation.</value>

IPPDotNetDevKitCSV3/Code/Intuit.Ipp.Exception/SdkExceptions/BatchItemsExceededException.cs

@@ -24,7 +24,7 @@ namespace Intuit.Ipp.Exception
     using Intuit.Ipp.Exception.Properties;
 
     /// <summary>
-    /// Represents an Exception raised when an batch collection exceeds 25 items.
+    /// Represents an Exception raised when an batch collection exceeds 30 items.
     /// </summary>
     [System.Serializable]
     public class BatchItemsExceededException : SdkException

IPPDotNetDevKitCSV3/Code/Intuit.Ipp.Nupkg/Intuit.Ipp.Nupkg.csproj

@@ -9,7 +9,7 @@
     <PackageId>IppDotNetSdkForQuickBooksApiV3</PackageId>
     <AssemblyName>IppDotNetSdkForQuickBooksApiV3</AssemblyName>
     <DocumentationFile>$(BaseOutputPath)$(AssemblyName).xml</DocumentationFile>
-    <MainVersion>14.7.0.2</MainVersion>
+    <MainVersion>14.7.0.3</MainVersion>
     <PackageVersionSuffix>pre</PackageVersionSuffix>
     <Version>$(MainVersion)-$(PackageVersionSuffix)</Version>
     <Version>$(MainVersion)</Version>

IPPDotNetDevKitCSV3/Code/Intuit.Ipp.ReportService/Properties/Resources.resx

@@ -112,10 +112,10 @@
     <value>2.0</value>
   </resheader>
   <resheader name="reader">
-    <value>System.Resources.ResXResourceReader, System.Windows.Forms, Version=9.1.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
+    <value>System.Resources.ResXResourceReader, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
   </resheader>
   <resheader name="writer">
-    <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=9.1.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
+    <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
   </resheader>
   <data name="CommunicationErrorMessage" xml:space="preserve">
     <value>There was an error while communicating with the Ids Server.</value>
@@ -178,6 +178,6 @@
     <value>string parameter can not be null or empty.</value>
   </data>
   <data name="batchItemsExceededMessage" xml:space="preserve">
-    <value>Number of Items in Batch Request exceeded the permissible limit of 25 items.</value>
+    <value>Number of Items in Batch Request exceeded the permissible limit of 30 items.</value>
   </data>
 </root>

IPPDotNetDevKitCSV3/Code/Intuit.Ipp.Utility/Common/CoreConstants.cs

@@ -250,7 +250,7 @@ public static class CoreConstants
         /// <summary>
         /// The Request source header value.
         /// </summary>
-        public const string REQUESTSOURCEHEADER = "V3DotNetSDK14.7.0.2";
+        public const string REQUESTSOURCEHEADER = "V3DotNetSDK14.7.0.3";
 
         /// <summary>
         /// multipart/form-data format

IPPDotNetDevKitCSV3/Tools/XsdExtension/Intuit.Ipp.Data/Directory.Build.props

@@ -13,8 +13,8 @@
     <PackageOutputPath>$(SolutionDir)artifacts\nupkg</PackageOutputPath>
     <OutputPath>$(SolutionDir)artifacts\bin</OutputPath>
     <Copyright>Copyright © 2020 Intuit, Inc.</Copyright>
-    <AssemblyVersion>14.7.0.2</AssemblyVersion>
-    <FileVersion>14.7.0.2</FileVersion>
+    <AssemblyVersion>14.7.0.3</AssemblyVersion>
+    <FileVersion>14.7.0.3</FileVersion>
     <Company>Intuit</Company>
     <AppendTargetFrameworkToOutputPath>true</AppendTargetFrameworkToOutputPath>
     <AppendRuntimeIdentifierToOutputPath>false</AppendRuntimeIdentifierToOutputPath>