improved code actions

Author: Corneliu Tusnea

.github/PUBLISHING.md

@@ -3,6 +3,8 @@
 This document explains how to publish ISL artifacts to Maven Central and GitHub Packages.
 
 ## Prerequisites
+https://intuit-teams.slack.com/archives/C044PJN2NDR/p1749599979127989?thread_ts=1749145553.673049&cid=C044PJN2NDR
+
 
 ### 1. Maven Central (Sonatype OSSRH) Setup
 
@@ -16,24 +18,38 @@ To publish to Maven Central, you need:
 
 ```bash
 # Generate key
-gpg --gen-key
+gpg --full-generate-key
+# Choose RSA (option 1), key size 3072 or 4096, and set a strong passphrase
+
+# List keys to get the key ID
+gpg --list-secret-keys --keyid-format=long
+
+# Export the ASCII-armored secret key (replace KEY_ID with your key ID)
+gpg --export-secret-keys --armor KEY_ID
+```
+
+**For Windows (PowerShell):**
+```powershell
+# Generate key
+gpg --full-generate-key
 
-# List keys to get the key ID (last 8 characters of the fingerprint)
-gpg --list-keys
+# List keys
+gpg --list-secret-keys --keyid-format=long
 
-# Export the key (replace KEY_ID with your key ID)
-gpg --export-secret-keys KEY_ID | base64
+# Export and copy to clipboard
+gpg --export-secret-keys --armor YOUR_KEY_ID | Set-Clipboard
 ```
 
+**Note:** You can use the ASCII-armored key directly in the `SIGNING_KEY` secret (starts with `-----BEGIN PGP PRIVATE KEY BLOCK-----`). Base64 encoding is optional.
+
 ### 2. GitHub Repository Secrets
 
 Configure the following secrets in your GitHub repository (Settings → Secrets and variables → Actions):
 
 #### Maven Central Secrets:
 - `OSSRH_USERNAME`: Your Sonatype JIRA username
 - `OSSRH_PASSWORD`: Your Sonatype JIRA password
-- `SIGNING_KEY_ID`: Your GPG key ID (last 8 characters)
-- `SIGNING_KEY`: Your base64-encoded GPG private key
+- `SIGNING_KEY`: Your ASCII-armored GPG private key (or base64-encoded)
 - `SIGNING_PASSWORD`: Your GPG key passphrase
 
 #### GitHub Packages:
@@ -167,6 +183,17 @@ signing.secretKeyRingFile=/path/to/.gnupg/secring.gpg
 
 ## Troubleshooting
 
+### Issue: "Could not read PGP secret key" or "checksum mismatch"
+**Solution:** 
+1. Use the ASCII-armored format directly (recommended):
+   ```bash
+   gpg --export-secret-keys --armor YOUR_KEY_ID
+   ```
+   Copy the entire output (including BEGIN/END markers) into the `SIGNING_KEY` secret
+2. Ensure `SIGNING_PASSWORD` matches your GPG key passphrase
+3. Verify the key exports correctly before adding to GitHub secrets
+4. If using base64 encoding, ensure no extra whitespace or line breaks are introduced
+
 ### Issue: "Could not find signing key"
 **Solution:** Ensure GPG key is properly exported and base64 encoded. Check `SIGNING_KEY` secret.
 

isl-transform/src/jmh/resources/shopify-transform.isl

@@ -9,7 +9,7 @@ fun convertAddress( $addr ) {
     $zip = $addr.zip | trim;
     $country = $addr.country_code | trim | upperCase;
     $formatted = `${$street}, ${$city}, ${$state} ${$zip}` | trim;
-    
+
     return { street: $street, city: $city, state: $state, zipCode: $zip, country: $country, formatted: $formatted };
 }
 
@@ -21,8 +21,8 @@ fun convertCustomer( $cust ) {
     $orders = $cust.orders_count | to.number;
     $spent = $cust.total_spent | to.decimal | precision(2);
     $addr = @.This.convertAddress( $cust.default_address );
-    
-    return { id: $cust.id | to.string, fullName: `${$firstName} ${$lastName}` | trim, firstName: $firstName, lastName: $lastName, email: $email, phone: $cust.phone | trim, totalOrders: $orders, lifetimeValue: $spent, address: $addr };
+
+    return { id: $cust.id | to.string, fullName: `$firstName ${$lastName}` | trim, firstName: $firstName, lastName: $lastName, email: $email, phone: $cust.phone | trim, totalOrders: $orders, lifetimeValue: $spent, address: $addr };
 }
 
 // Helper function: Process and enrich line item
@@ -36,8 +36,10 @@ fun processLineItem( $item ) {
     $lineTotal = {{ $price * $qty }} | Math.clamp(0, 999999) | precision(2);
     $weightKg = {{ $weight / 1000 }} | precision(3);
     $productCode = `${$sku}-${$item.product_id | to.string}` | upperCase;
-    
-    return { itemId: $item.id | to.string, sku: $sku, productCode: $productCode, name: $name, vendor: $vendor, quantity: $qty, unitPrice: $price, lineTotal: $lineTotal, weight: $weight, weightKg: $weightKg, variantTitle: $item.variant_title | trim };
+
+    return $item | to.string;
+
+    // return { itemId: $item.id | to.string, sku: `$sku $test` | trim, productCode: $productCode, name: $name, vendor: $vendor, quantity: $qty, unitPrice: $price, lineTotal: $lineTotal, weight: $weight, weightKg: $weightKg, variantTitle: $item.variant_title | trim };
 }
 
 // Main entry point
@@ -46,13 +48,21 @@ fun run( $input ) {
     $orderId = $input.id | to.string;
     $orderNum = $input.order_number | to.string | padStart(8, "0");
     $orderName = $input.name | trim;
-    
+
     // Convert customer with enrichment
     $customer = @.This.convertCustomer( $input.customer );
-    
+
+
+
+    $obj.x = 10;
+    $obj.a.d = 2;
+    $obj.a.b.c = 1;
+    $obj.y.z = 20;
+    $obj.a.b.e = 3;
+
     // Process all line items with enrichment using map with implicit $ iterator
     $processedItems = $input.line_items | map( @.This.processLineItem( $ ) );
-    
+
     // Calculate order statistics using map/reduce with implicit $ iterator
     $totalItems = $input.line_items | length | to.number;
     $quantities = $input.line_items | map( $.quantity | to.number );
@@ -63,34 +73,34 @@ fun run( $input ) {
     $premiumCount = $input.line_items | filter( $.price | to.decimal >= 100 ) | length | to.number;
     $vendors = $input.line_items | map( $.vendor | trim | titleCase ) | unique | sort;
     $vendorCount = $vendors | length | to.number;
-    
+
     // Financial calculations
     $subtotal = $input.subtotal_price | to.decimal | precision(2);
     $shippingCost = $input.total_shipping_price_set.shop_money.amount | to.decimal | precision(2);
     $tax = $input.total_tax | to.decimal | precision(2);
     $discounts = $input.total_discounts | to.decimal | precision(2);
     $total = $input.total_price | to.decimal | precision(2);
     $finalTotal = {{ $total - $discounts }} | Math.clamp(0, 999999) | precision(2);
-    
+
     // Determine shipping method and status with conditionals
     $fulfillmentStatus = $input.fulfillment_status | trim | upperCase;
     $shippingStatus = if( $fulfillmentStatus == "FULFILLED" ) "DELIVERED" else "PENDING";
     $shippingSpeed = if( $shippingCost >= 20 ) "EXPRESS" else "STANDARD";
-    
+
     // Build shipping information
     $shippingAddr = @.This.convertAddress( $input.shipping_address );
-    
+
     // Process note attributes using map with implicit $ iterator
     $noteKeys = $input.note_attributes | map( $.name | trim );
     $noteValues = $input.note_attributes | map( $.value | trim );
-    
+
     // Extract and process tags using map
     $tags = $input.tags | split(",") | map( $ | trim | upperCase );
-    
+
     // Status flags with conditionals
     $isPaid = if( $input.financial_status | trim | lowerCase == "paid" ) true else false;
     $isFulfilled = if( $fulfillmentStatus == "FULFILLED" ) true else false;
-    
+
     // Build final result with all transformations
     orderId: $orderId;
     orderNumber: $orderNum;
@@ -135,3 +145,5 @@ fun run( $input ) {
     isFulfilled: $isFulfilled;
     summary: `Order ${$orderNum} - ${$customer.fullName} - ${$finalTotal} ${$input.currency | trim | upperCase} - ${$totalItems} items` | trim;
 }
+
+

plugin/package.json

@@ -77,6 +77,11 @@
           "default": false,
           "description": "Use tabs instead of spaces"
         },
+        "isl.formatting.alignProperties": {
+          "type": "boolean",
+          "default": false,
+          "description": "Align object property colons"
+        },
         "isl.linting.enabled": {
           "type": "boolean",
           "default": true,

plugin/snippets/isl.json

@@ -176,6 +176,172 @@
       "${1:\\$date} | to.string(\"${2:yyyy-MM-dd HH:mm:ss}\")"
     ],
     "description": "Format date"
+  },
+  "ISL Transform Object Keys": {
+    "prefix": "transformkeys",
+    "body": [
+      "foreach \\$key in ${1:\\$object} | keys",
+      "\t`\\${\\$key}`: ${1:\\$object}[\\$key]$0",
+      "endfor"
+    ],
+    "description": "Transform all keys of an object"
+  },
+  "ISL Safe Navigation": {
+    "prefix": "safe",
+    "body": [
+      "${1:\\$value} ?? ${2:defaultValue}"
+    ],
+    "description": "Null coalescing operator"
+  },
+  "ISL Array to Object": {
+    "prefix": "arrtoobj",
+    "body": [
+      "${1:\\$array} | map({",
+      "\t`\\${${2:\\$item.key}}`: ${3:\\$item.value}",
+      "})"
+    ],
+    "description": "Convert array to object"
+  },
+  "ISL Conditional Field": {
+    "prefix": "condfield",
+    "body": [
+      "if (${1:condition})",
+      "\t${2:fieldName}: ${3:value}",
+      "endif"
+    ],
+    "description": "Conditional object field"
+  },
+  "ISL Error Handling": {
+    "prefix": "errorhandle",
+    "body": [
+      "${1:\\$value} | default(${2:fallbackValue})"
+    ],
+    "description": "Provide default value on error"
+  },
+  "ISL Spread Object": {
+    "prefix": "spread",
+    "body": [
+      "{",
+      "\t...${1:\\$object},",
+      "\t${2:newField}: ${3:value}",
+      "}"
+    ],
+    "description": "Spread operator to merge objects"
+  },
+  "ISL Filter and Map": {
+    "prefix": "filtermap",
+    "body": [
+      "${1:\\$array}",
+      "\t| filter(${2:condition})",
+      "\t| map(${3:expression})"
+    ],
+    "description": "Filter then map array"
+  },
+  "ISL Reduce Sum": {
+    "prefix": "reducesum",
+    "body": [
+      "${1:\\$array} | reduce({{ \\$acc + \\$it }}, 0)"
+    ],
+    "description": "Reduce array to sum"
+  },
+  "ISL Template String": {
+    "prefix": "template",
+    "body": [
+      "`${${1:expression}}`"
+    ],
+    "description": "Template string with interpolation"
+  },
+  "ISL Multi-line String": {
+    "prefix": "multiline",
+    "body": [
+      "`${1:line1}",
+      "${2:line2}",
+      "${3:line3}`"
+    ],
+    "description": "Multi-line template string"
+  },
+  "ISL Nested Object": {
+    "prefix": "nested",
+    "body": [
+      "{",
+      "\t${1:field1}: {",
+      "\t\t${2:nested}: ${3:value}",
+      "\t}",
+      "}"
+    ],
+    "description": "Nested object structure"
+  },
+  "ISL Array Destructure": {
+    "prefix": "destruct",
+    "body": [
+      "\\$${1:first} = ${2:\\$array} | first;",
+      "\\$${3:last} = ${2:\\$array} | last;"
+    ],
+    "description": "Destructure array"
+  },
+  "ISL Chain Modifiers": {
+    "prefix": "chain",
+    "body": [
+      "${1:\\$value}",
+      "\t| ${2:modifier1}",
+      "\t| ${3:modifier2}",
+      "\t| ${4:modifier3}"
+    ],
+    "description": "Chain multiple modifiers"
+  },
+  "ISL Fallback Chain": {
+    "prefix": "fallback",
+    "body": [
+      "${1:\\$primary} ?? ${2:\\$secondary} ?? ${3:default}"
+    ],
+    "description": "Multiple fallback values"
+  },
+  "ISL Custom Object Key": {
+    "prefix": "dynamickey",
+    "body": [
+      "{",
+      "\t`\\${${1:expression}}`: ${2:value}",
+      "}"
+    ],
+    "description": "Object with dynamic key"
+  },
+  "ISL Validate and Transform": {
+    "prefix": "validate",
+    "body": [
+      "if (${1:\\$input.field} | isNotEmpty)",
+      "\t${2:result}: ${1:\\$input.field} | ${3:transform}",
+      "else",
+      "\t${2:result}: ${4:defaultValue}",
+      "endif"
+    ],
+    "description": "Validate before transforming"
+  },
+  "ISL Date Range": {
+    "prefix": "daterange",
+    "body": [
+      "\\$start = ${1:\\$date};",
+      "\\$end = ${1:\\$date} | date.add(${2:7}, \"${3:DAYS}\");"
+    ],
+    "description": "Create date range"
+  },
+  "ISL Group By": {
+    "prefix": "groupby",
+    "body": [
+      "foreach \\$item in ${1:\\$array}",
+      "\t\\$key = \\$item.${2:groupField};",
+      "\t\\$grouped[\\$key] = (\\$grouped[\\$key] ?? []) | push(\\$item);",
+      "endfor"
+    ],
+    "description": "Group array by field"
+  },
+  "ISL Batch Process": {
+    "prefix": "batch",
+    "body": [
+      "parallel foreach \\$item in ${1:\\$array}",
+      "\t@.This.${2:processFunction}(\\$item)",
+      "endfor"
+    ],
+    "description": "Parallel batch processing"
   }
 }