url: relax check to ignore semicolons in URLs

* according to RFC 1738 section 2.2, semicolons are reserved but valid
  characters in URIs
* `urllib.parse.urlparse()` interprets semicolons as `params`
* thus, the check for no params in `is_url()` returns `False` for some
  valid URLs

Author: max-moser

CHANGES.rst

@@ -15,6 +15,10 @@
 Changes
 =======
 
+Version <next>
+
+- is_url: allow URL parameters (i.e. semicolon)
+
 Version 1.4.2 (2024-11-01)
 
 - setup: remove pytest-invenio to make imports cleaner

idutils/validators.py

@@ -172,7 +172,7 @@ def is_purl(val):
 def is_url(val):
     """Test if argument is a URL."""
     res = urlparse(val)
-    return bool(res.scheme and res.netloc and res.params == "")
+    return bool(res.scheme and res.netloc)
 
 
 def is_lsid(val):

tests/test_idutils.py

@@ -870,6 +870,13 @@ def test_doi():
     assert not idutils.is_doi("10.1.NOTGOOD.0/123456")
 
 
+def test_url():
+    """Test URL validation."""
+    for i, expected_schemes, normalized_value, url_value in identifiers:
+        if url_value:
+            assert idutils.is_url(url_value)
+
+
 def test_ascl():
     """Test ASCL validation."""
     assert idutils.is_ascl("ascl:1908.011")